Bug in handling events?

Hi,

I’ve just found that all SDL_Private* functions (MouseButton, MouseMove,
Joystick*…) do not return value of SDL_PushEvent(). They just return 1
if event was ment to be pushed to queue, but not if it was really added to
queue or not.
Is it like that for some special reason? Shouldn’t it return 1 ONLY if
event was really added to queue?

I can make patch (it’s not so hard to scan for SDL_private, hehe :), but i
don’t know if it’s ok or not to change that.

Regards
ahwayakchih

Hi,

I’ve just found that all SDL_Private* functions (MouseButton, MouseMove,
Joystick*…) do not return value of SDL_PushEvent(). They just return 1
if event was ment to be pushed to queue, but not if it was really added to
queue or not.
Is it like that for some special reason? Shouldn’t it return 1 ONLY if
event was really added to queue?

I can make patch (it’s not so hard to scan for SDL_private, hehe :), but i
don’t know if it’s ok or not to change that.

It’s fine the way it is… it just returns true if the application wants to
see the event, not whether the event was successfully queued.

See ya,
-Sam Lantinga, Software Engineer, Blizzard Entertainment