Bug in SDL_dx5video.c

SDL Development
1

http://www.libsdl.org/cgi/cvsweb.cgi/SDL12/src/video/windx5/SDL_dx5video.c.diff?r1=1.15&r2=1.16

if ( was_visible && !(flags & SDL_FULLSCREEN) ) {
swp_flags |= SWP_NOMOVE;
}

was changed to

if ( was_visible && (flags & SDL_FULLSCREEN) ) {

This doesn’t make sense to me - apparently the original
idea was to prevent moving the window if it was already
visible, unless we are going to fullscreen. Nice. After
the change I end up with fullscreen windows that are
somewhere else than top-left.

2

http://www.libsdl.org/cgi/cvsweb.cgi/SDL12/src/video/windx5/SDL_dx5video.c.diff?r1=1.15&r2=1.16

if ( was_visible && !(flags & SDL_FULLSCREEN) ) {
swp_flags |= SWP_NOMOVE;
}

was changed to

if ( was_visible && (flags & SDL_FULLSCREEN) ) {

This doesn’t make sense to me - apparently the original
idea was to prevent moving the window if it was already
visible, unless we are going to fullscreen. Nice. After
the change I end up with fullscreen windows that are
somewhere else than top-left.

Thanks for catching that, that was a typo.

See ya!
-Sam Lantinga, Software Engineer, Blizzard Entertainment