[BUG] rev 5603 causes never ending Error: Couldn't open stream

SDL Development
1

Hi,

Just wanted to notify you that fix commited in 5603 e1ca92e7f2ff “X11 touch handling fixed for one device (LPC32xx Touchscreen)” treats some other (normal Parallels keyboards) as touch screen. The fault is “lpc32xx_ts.c” Linux driver which defines VENDOR to 0x1 and PRODUCT 0x2 to bogus values:

http://lxr.linux.no/linux+v3.0.4/drivers/input/touchscreen/lpc32xx_ts.c#L259

These are not actual vendor or product IDs as known from other USB devices, so SDL shouldn’t relay on that, because other built-in devices such as keyboards may report similar values (this is the case of standard PC keyboard in Parallels) which causes SDL to think it is touch device and later emit lots lots of: “Error: Couldn’t open stream”

I’d recommend rolling back this patch, or identifying this device by name, not bogus VENDOR identifier.

Regards,–
Adam Strzelecki

2

Just wanted to notify you that fix commited in 5603 e1ca92e7f2ff “X11
touch handling fixed for one device (LPC32xx Touchscreen)” treats some
other (normal Parallels keyboards) as touch screen. The fault is
“lpc32xx_ts.c” Linux driver which defines VENDOR to 0x1 and PRODUCT 0x2
to bogus values:

We should really rip the X11 multitouch code out…besides the fact it
touches Linux-specific device nodes and looks generally prone to
breakage, x.org has a proper multitouch extension we should be using
instead.

–ryan.