Current CVS version of SDL became broken

SDL Development
1

Hello, All!

That patch causes segfault, when trying to run lbreakout2 version 2.5.2 (can
be downloaded from http://lgames.sf.net ):

2005-01-12 19:38 slouken

  • src/video/SDL_pixels.c: Clarified the code in the pixel format
    allocation Added support for direct color 8-bpp modes.

SDL_pixels.c have revision 1.13, I’ve checked out previous 1.12 revision
without that patch, all working fine !

I’m right now fixing QNX6 code of SDL, so haven’t a much free time to
discover what happens in SDL internals, but looks like palette is not
created for some surfaces, and without checking it for NULL it passed to
Map1toN() function where it segfaults. But the root of the problem located
in this applied patch.

// lmike
With best regards, Mike Gorchak. E-mail: @Mike_Gorchak

2

i posted this same report almost a month ago but no one responded :confused:
http://twomix.devolution.com/pipermail/sdl/2005-January/066957.html
-mikeOn Friday 18 February 2005 12:53 am, Mike Gorchak wrote:

That patch causes segfault, when trying to run lbreakout2 version 2.5.2
(can be downloaded from http://lgames.sf.net ):

3

Hello, All!

That patch causes segfault, when trying to run lbreakout2 version 2.5.2 (can
be downloaded from http://lgames.sf.net ):

2005-01-12 19:38 slouken

  • src/video/SDL_pixels.c: Clarified the code in the pixel format
    allocation Added support for direct color 8-bpp modes.

SDL_pixels.c have revision 1.13, I’ve checked out previous 1.12 revision
without that patch, all working fine !

I’m right now fixing QNX6 code of SDL, so haven’t a much free time to
discover what happens in SDL internals, but looks like palette is not
created for some surfaces, and without checking it for NULL it passed to
Map1toN() function where it segfaults. But the root of the problem located
in this applied patch.

By the way, we have a better fix for that in the works, thanks for reporting it.

See ya,
-Sam Lantinga, Software Engineer, Blizzard Entertainment

4

That patch causes segfault, when trying to run lbreakout2 version 2.5.2 (can
be downloaded from http://lgames.sf.net ):

2005-01-12 19:38 slouken

  • src/video/SDL_pixels.c: Clarified the code in the pixel format
    allocation Added support for direct color 8-bpp modes.

SDL_pixels.c have revision 1.13, I’ve checked out previous 1.12 revision
without that patch, all working fine !

Can you check this with the latest CVS?

Thanks!
-Sam Lantinga, Software Engineer, Blizzard Entertainment