Failure in going to fullscreen on Mac

amruthraj · October 20, 2017, 10:38am

This question is specific to Mac.

After an app calls SDL_SetWindowFullscreen(), if there is a failure in going to fullscreen through NSWindowDidFailToEnterFullScreenNotification, how can the app know it?

As far as I see, there is an API SDL_GetWindowFlags(), which returns window->flags, but I want to know if this variable reflects this particular failure. Or if there are any other ways, please let me know.

Thanks.

amruthraj · October 23, 2017, 6:00am

Ping. Can anyone please help?

Jacob_Lifshay · October 23, 2017, 9:42am

It appears as though the fullscreen flag might get reset on receiving the
notification, however I am not familiar with either Cocoa or SDL’s Cocoa
backend so I can’t say for sure. The source code for the notification
handler:

github.com

spurious/SDL-mirror/blob/323a05942bd4f38aeaefc8d48081060079cc6ace/src/video/cocoa/SDL_cocoawindow.m#L684


- (void)windowWillEnterFullScreen:(NSNotification *)aNotification
{
SDL_Window *window = _data->window;


SetWindowStyle(window, (NSWindowStyleMaskTitled|NSWindowStyleMaskClosable|NSWindowStyleMaskMiniaturizable|NSWindowStyleMaskResizable));


isFullscreenSpace = YES;
inFullscreenTransition = YES;
}


- (void)windowDidFailToEnterFullScreen:(NSNotification *)aNotification
{
SDL_Window *window = _data->window;


if (window->is_destroying) {
    return;
}


SetWindowStyle(window, GetWindowStyle(window));


isFullscreenSpace = NO;