From 4bea983cfd06205a482b028c77291b2a51cfaddb Mon Sep 17 00:00:00 2001
From: Ozkan Sezer <[EMAIL REDACTED]>
Date: Thu, 5 Oct 2023 11:56:24 +0300
Subject: [PATCH] Vgm_Emu::Vgm_Emu() : initialize psg_dual and psg_t6w28.
Cures the valgrind warnings:
Loading file ../../test.vgz by file path...
==26165== Conditional jump or move depends on uninitialised value(s)
==26165== at 0x41E3509: Vgm_Emu::update_eq(blip_eq_t const&) (Vgm_Emu.cpp:262)
==26165== by 0x41A0469: Classic_Emu::set_equalizer_(gme_equalizer_t const&) (Classic_Emu.cpp:41)
==26165== by 0x41AC9BB: Music_Emu::set_equalizer(gme_equalizer_t const&) (Music_Emu.cpp:101)
==26165== by 0x41E2D44: Vgm_Emu::Vgm_Emu() (Vgm_Emu.cpp:43)
==26165== by 0x41E32DE: new_vgm_emu() (Vgm_Emu.cpp:206)
==26165== by 0x41A8E62: gme_internal_new_emu_(gme_type_t_ const*, int, bool) (gme.cpp:223)
==26165== by 0x41A8FC8: gme_new_emu (gme.cpp:260)
==26165== by 0x41A8CCF: gme_open_file (gme.cpp:186)
==26165== by 0x804A480: Music_Player::load_file(char const*, bool) (Music_Player.cpp:115)
==26165== by 0x804AD82: main (player.cpp:121)
Fixes: https://bitbucket.org/mpyne/game-music-emu/issues/246
Co-authored-by: Wohlstand <admin@wohlnet.ru>
(cherry picked from commit b3ba9e886a8b3e470b07da98d291b1413dd606d0)
---
gme/Vgm_Emu.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gme/Vgm_Emu.cpp b/gme/Vgm_Emu.cpp
index af59c5e..97f52a9 100644
--- a/gme/Vgm_Emu.cpp
+++ b/gme/Vgm_Emu.cpp
@@ -30,6 +30,8 @@ using std::max;
Vgm_Emu::Vgm_Emu()
{
disable_oversampling_ = false;
+ psg_dual = false;
+ psg_t6w28 = false;
psg_rate = 0;
set_type( gme_vgm_type );