glGetError issue in the gl renderers

Hi,

currently there are errors in the opengl renderer of sdl - and it’s hard
to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see attachment)
would at least print multiple errors to the registered
SDL_LogSetOutputFunction callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it - it’s
just there for you to know what I’m talking about.
-------------- next part --------------
A non-text attachment was scrubbed…
Name: glerrorcheck.c
Type: text/x-csrc
Size: 1100 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20120826/ea51b9cd/attachment.c

Are you saying this for the SDL Renderer, or for SDL’s OpenGL window?On Sun, Aug 26, 2012 at 7:14 AM, Martin Gerhardy <martin.gerhardy at gmail.com>wrote:

Hi,

currently there are errors in the opengl renderer of sdl - and it’s hard
to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see attachment) would
at least print multiple errors to the registered SDL_LogSetOutputFunction
callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it - it’s just
there for you to know what I’m talking about.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

I’m talking about SDL_render_gl.c and maybe also about the gles versions.Am 26.08.2012 13:22, schrieb Alex Barry:

Are you saying this for the SDL Renderer, or for SDL’s OpenGL window?

On Sun, Aug 26, 2012 at 7:14 AM, Martin Gerhardy <@Martin_Gerhardy mailto:Martin_Gerhardy> wrote:

Hi,

currently there are errors in the opengl renderer of sdl - and
it's hard to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see
attachment) would at least print multiple errors to the registered
SDL_LogSetOutputFunction callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it -
it's just there for you to know what I'm talking about.

_______________________________________________
SDL mailing list
SDL at lists.libsdl.org <mailto:SDL at lists.libsdl.org>
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Hi,

This looks like a good suggestion - why don’t you post a bug in bugzilla
with this code attached?

I am facing weird problems with the opengl renderer too. If I used
SDL_TEXTUREACCESS_STATIC flag while creating textures, they render fine,
if I use SDL_TEXTUREACCESS_STREAMING instead the behaviour is erratic,
with textures sometimes getting rendered, sometimes not, and I have no
idea why.

PallavOn 26-08-2012 16:44, Martin Gerhardy wrote:

Hi,

currently there are errors in the opengl renderer of sdl - and it’s
hard to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see attachment)
would at least print multiple errors to the registered
SDL_LogSetOutputFunction callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it - it’s
just there for you to know what I’m talking about.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Pallav Nawani
Game Designer/CEO
http://www.ironcode.com
Twitter: http://twitter.com/Ironcode_Gaming
Facebook: http://www.facebook.com/Ironcode.Gaming

ok, i will prepare a patch and post it in bugzilla.Am 27.08.2012 09:20, schrieb Pallav Nawani:

Hi,

This looks like a good suggestion - why don’t you post a bug in
bugzilla with this code attached?

I am facing weird problems with the opengl renderer too. If I used
SDL_TEXTUREACCESS_STATIC flag while creating textures, they render
fine, if I use SDL_TEXTUREACCESS_STREAMING instead the behaviour is
erratic, with textures sometimes getting rendered, sometimes not, and
I have no idea why.

Pallav

On 26-08-2012 16:44, Martin Gerhardy wrote:

Hi,

currently there are errors in the opengl renderer of sdl - and it’s
hard to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see attachment)
would at least print multiple errors to the registered
SDL_LogSetOutputFunction callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it - it’s
just there for you to know what I’m talking about.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

here is the bugzilla ticket: http://bugzilla.libsdl.org/show_bug.cgi?id=1584Am 27.08.2012 09:20, schrieb Pallav Nawani:

Hi,

This looks like a good suggestion - why don’t you post a bug in
bugzilla with this code attached?

I am facing weird problems with the opengl renderer too. If I used
SDL_TEXTUREACCESS_STATIC flag while creating textures, they render
fine, if I use SDL_TEXTUREACCESS_STREAMING instead the behaviour is
erratic, with textures sometimes getting rendered, sometimes not, and
I have no idea why.

Pallav

On 26-08-2012 16:44, Martin Gerhardy wrote:

Hi,

currently there are errors in the opengl renderer of sdl - and it’s
hard to find them, because glGetError is not called correctly.

Using something like the proposed GL_CheckAllErrors (see attachment)
would at least print multiple errors to the registered
SDL_LogSetOutputFunction callback.

Opinions?

Greetings
Martin

PS. the code is not tested and I not even tried to compile it - it’s
just there for you to know what I’m talking about.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org