Including SDL_endian.h ...?

Is there a reason that SDL.h doesn’t automatically include SDL_endian.h?
It’s easy enough to include by itself in a given application, but I was
curious if this was an oversight, or intentional?

–ryan.

“Ryan C. Gordon” wrote:

Is there a reason that SDL.h doesn’t automatically include SDL_endian.h?

it’s probably an oversight. I see no reason not to include it

“Ryan C. Gordon” wrote:

Is there a reason that SDL.h doesn’t automatically include SDL_endian.h?

it’s probably an oversight. I see no reason not to include it

On Linux it includes some system headers, and when used with compilers that
don’t support inline functions, it results in a bunch of statically defined
byte swapping functions which can bloat code if the compiler isn’t smart
enough to remove unreferenced code.

I don’t know that these are compelling reasons, but that’s why it hasn’t
been done so far…

See ya,
-Sam Lantinga, Software Engineer, Blizzard Entertainment

It sounds contrary to portability I realize, but is the concern about
compilers that do not even provide this most basic optimization reasonable
on the platforms SDL compiles on? Even the most pathetic and broken of
compilers I have seen do that much. MSVC is even smart enough for that
much (okay, I couldn’t resist after the last sentance…)

Seriously though, asm/byteorder.h may be a valid reason not to add the
file to SDL.h on principle. The contents of the file indicate trivial
enough I personally am not concerned in this case. It’s your library
though, so your call. =)On Sun, Sep 23, 2001 at 12:12:00AM -0700, Sam Lantinga wrote:

it’s probably an oversight. I see no reason not to include it

On Linux it includes some system headers, and when used with compilers that
don’t support inline functions, it results in a bunch of statically defined
byte swapping functions which can bloat code if the compiler isn’t smart
enough to remove unreferenced code.


Joseph Carter Free software developer

oh, besides, whats the best approach if i want to make a Quake
level designed from an existing building?
Get a floorplan of Brian’s office? =)
Knghtbrd: im considering my school.
Oh great
That’s ALL we need

-------------- next part --------------
A non-text attachment was scrubbed…
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20010923/1ac8848f/attachment-0007.pgp

Joseph Carter wrote:

Seriously though, asm/byteorder.h may be a valid reason not to add the
file to SDL.h on principle. The contents of the file indicate trivial
enough I personally am not concerned in this case. It’s your library
though, so your call. =3D)

there are good reasons to rewrite the macros for 1.3 anyway (i.e. to
take advantage of the fact that several architectures have
byte-swapping load/stores but not in-register conversions)