Issue with 1.2.8 and mingw

OK, I compiled something using SDL 1.2.7, and I was trying to explain over
IRC to someone else how to compile it. They are using SDL 1.2.8. They got
the compile error:

SDL_audio.h:97: error: syntax error before `[’ token

Apparently their SDL_audio.h line 97 reads:

void (SDLCALL *filters[10])(struct SDL_AudioCVT *cvt, Uint16 format);

Mine reads:

void (*filters[10])(struct SDL_AudioCVT *cvt, Uint16 format);

This change is from the following CVS commit:Date: Fri, 20 Aug 2004 08:31:20 +0200
From: "Markus F.X.J. Oberhumer"
Subject: [SDL-CVS][patch] add missing SDLCALL to headers

the small patch attached below (against current CVS) adds some missing
SDLCALL
decorations to callback types and arguments.

In 1.2.8 begin_code.h there is:

#ifndef SDLCALL
#ifdef WIN32
#define SDLCALL __cdecl

The MSN developers network says __cdecl is a Microsoft only function, maybe
this is the issue?

Thanks,

James

OK, I compiled something using SDL 1.2.7, and I was trying to explain over
IRC to someone else how to compile it. They are using SDL 1.2.8. They got
the compile error:

SDL_audio.h:97: error: syntax error before `[’ token

Apparently their SDL_audio.h line 97 reads:

void (SDLCALL *filters[10])(struct SDL_AudioCVT *cvt, Uint16 format);

Just remove SDLCALL from that line. It’s a bug in the gcc parser.

Thanks!
-Sam Lantinga, Software Engineer, Blizzard Entertainment