Null pointer dereference if window name is null

Hello,
I am doing some weird stuff with SDL and I found a few corner cases in
which I can get SDL to dereference null pointers, here is a patch to fix
that.–

  I am doing some weird stuff with SDL and I found a few corner

cases in which I can get SDL to dereference null pointers, here is a
patch to fix that.

How are you setting data with a NULL name in the first place? Wouldn’t a
call to SDL_SetWindowData() with a NULL name crash in the SDL_strdup() call?

–ryan.

Applied - plus added some input validation so you shouldn’t even be able
to set a NULL name anymore.
http://hg.libsdl.org/SDL/rev/8d5636aafd1cOn 4/1/2013 1:36 PM, Joseph Toppi wrote:

Hello,
I am doing some weird stuff with SDL and I found a few corner
cases in which I can get SDL to dereference null pointers, here is a
patch to fix that.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Ryan,
Sorry, to answer late, but we are creating our windows with Ogre3d and
pass the Hwnd, X11 Window or NSWindow* it creates into SDL via
SDL_CreateWindowFrom. So I guess Ogre leaves the name null.On Tue, Apr 2, 2013 at 10:41 AM, Andreas Schiffler wrote:

Applied - plus added some input validation so you shouldn’t even be able
to set a NULL name anymore.
http://hg.libsdl.org/SDL/rev/8d5636aafd1c

On 4/1/2013 1:36 PM, Joseph Toppi wrote:

Hello,
I am doing some weird stuff with SDL and I found a few corner cases
in which I can get SDL to dereference null pointers, here is a patch to fix
that.


SDL mailing listSDL at lists.libsdl.orghttp://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

  • Joe Toppi
    (402) 714-7539
    BlackTopp Studios Inc.
    Lead Software Developer
    Toppij at BlackToppStudios.com

To go with creating windows externally I have a patch that enables user
input to work on Linux from externally created windows. Using the
SDL_CreateWindowFrom function SDL allows Mac OS X and windows windows to
work, but without this user input events are not generated on Linux.On Tue, May 28, 2013 at 7:57 PM, Joseph Toppi <@Joseph_Toppi>wrote:

Ryan,
Sorry, to answer late, but we are creating our windows with Ogre3d and
pass the Hwnd, X11 Window or NSWindow* it creates into SDL via
SDL_CreateWindowFrom. So I guess Ogre leaves the name null.

On Tue, Apr 2, 2013 at 10:41 AM, Andreas Schiffler < aschiffler at ferzkopp.net> wrote:

Applied - plus added some input validation so you shouldn’t even be
able to set a NULL name anymore.
http://hg.libsdl.org/SDL/rev/8d5636aafd1c

On 4/1/2013 1:36 PM, Joseph Toppi wrote:

Hello,
I am doing some weird stuff with SDL and I found a few corner cases
in which I can get SDL to dereference null pointers, here is a patch to fix
that.


SDL mailing listSDL at lists.libsdl.orghttp://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

  • Joe Toppi
    (402) 714-7539
    BlackTopp Studios Inc.
    Lead Software Developer
    Toppij at BlackToppStudios.com