Patch: fixing uninitilized palette

Hi,

while running Valgrind over my application I found the following
problem in SDL:

The function MapNto1 allocates SDL_Color colors[256] but does not
initialize it.
SDL_DitherColors is then called which initialized the r, g and b
component, but not the ‘unused’ component of each color.
When Map1to1 is called from MapNto1, it runs a memcmp on the colors,
which also evaluates the unused component and therefor returns
differences much more often than necessary.

So the ‘unused’ component of SDL_Color should be initialized. This
patch does this by calling memset for the whole array in MapNto1 .

Regards,
Martin
-------------- next part --------------
A non-text attachment was scrubbed…
Name: not available
Type: application/octet-stream
Size: 704 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20041127/0ba5918c/attachment.obj

while running Valgrind over my application I found the following
problem in SDL:

The function MapNto1 allocates SDL_Color colors[256] but does not
initialize it.
SDL_DitherColors is then called which initialized the r, g and b
component, but not the ‘unused’ component of each color.
When Map1to1 is called from MapNto1, it runs a memcmp on the colors,
which also evaluates the unused component and therefor returns
differences much more often than necessary.

So the ‘unused’ component of SDL_Color should be initialized. This
patch does this by calling memset for the whole array in MapNto1 .

Thanks, I’ve added your patch to CVS.

See ya,
-Sam Lantinga, Software Engineer, Blizzard Entertainment