Patch for building on haiku

Hi,
With this patch, sdl 1.2 builds out of the box on Haiku.
Haiku is an open source reimplementation of beos, binary and source
compatible with it.
The only “problem” is that haiku doesn’t identify itself as beos, of
course (uname -a returns “Haiku shiryu 1 r29316 Feb 24 2009 20:31:44
BePC Haiku” on my computer), so the configure script needs to be
modified.
With this patch, sdl treats haiku just like beos. In the future, I
think we should differentiate the platforms, since Haiku is more posix
compatible, and it has some new api.

For the configure script to work properly, you should also include in
the sdl package a more updated config.sub and config.guess from
libtool.

I will also start to port sdl 1.3 to haiku.

The patch is against the svn head.
-------------- next part --------------
A non-text attachment was scrubbed…
Name: haiku.diff
Type: application/octet-stream
Size: 438 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20090226/3c3fbd0e/attachment.obj

Stefano,
Have you reviewed the patches we have at HaikuPorts? Perhaps they can
be refined and then merged into one, and then submitted?
http://ports.haiku-files.org/browser/haikuports/trunk/media-libs/libsdl
Seems your patch only touches configure.in, did you make sure the
tests all work? Parts of the patches on HaikuPorts are no longer
needed since Haiku dropped defining BEOS, so those parts need to
be updated.
-scottmcOn Thu, Feb 26, 2009 at 12:49 PM, Stefano Ceccherini <stefano.ceccherini at gmail.com> wrote:

Hi,
With this patch, sdl 1.2 builds out of the box on Haiku.
Haiku is an open source reimplementation of beos, binary and source
compatible with it.
The only “problem” is that haiku doesn’t identify itself as beos, of
course (uname -a returns “Haiku shiryu 1 r29316 Feb 24 2009 20:31:44
BePC Haiku” on my computer), so the configure script needs to be
modified.
With this patch, sdl treats haiku just like beos. In the future, I
think we should differentiate the platforms, since Haiku is more posix
compatible, and it has some new api.

For the configure script to work properly, you should also include in
the sdl package a more updated config.sub and config.guess from
libtool.

I will also start to port sdl 1.3 to haiku.

The patch is against the svn head.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

2009/2/26 scott mc :> On Thu, Feb 26, 2009 at 12:49 PM, Stefano Ceccherini <@Stefano_Ceccherini> wrote:

Hi,
With this patch, sdl 1.2 builds out of the box on Haiku.
Haiku is an open source reimplementation of beos, binary and source
compatible with it.
The only “problem” is that haiku doesn’t identify itself as beos, of
course (uname -a returns “Haiku shiryu 1 r29316 Feb 24 2009 20:31:44
BePC Haiku” on my computer), so the configure script needs to be
modified.
With this patch, sdl treats haiku just like beos. In the future, I
think we should differentiate the platforms, since Haiku is more posix
compatible, and it has some new api.

For the configure script to work properly, you should also include in
the sdl package a more updated config.sub and config.guess from
libtool.

I will also start to port sdl 1.3 to haiku.

The patch is against the svn head.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Stefano,
Have you reviewed the patches we have at HaikuPorts? ?Perhaps they can
be refined and then merged into one, and then submitted?
http://ports.haiku-files.org/browser/haikuports/trunk/media-libs/libsdl
Seems your patch only touches configure.in, did you make sure the
tests all work? ?Parts of the patches on HaikuPorts are no longer
needed since Haiku dropped defining BEOS, so those parts need to
be updated.
-scottmc


Hi Scott.

You are right, of course.
I forgot I had BEOS defined in my .profile so the build worked out
of the box.
I haven’t checked the patches on beports yet. I (wrongly) supposed
that if beports had a look at sdl, the patches would have already been
submitted.
Anyway, is there any reason why you didn’t submit the patches yet ?

2009/2/26 scott mc <@scott_mc>:

Hi,
With this patch, sdl 1.2 builds out of the box on Haiku.
Haiku is an open source reimplementation of beos, binary and source
compatible with it.
The only “problem” is that haiku doesn’t identify itself as beos, of
course (uname -a returns “Haiku shiryu 1 r29316 Feb 24 2009 20:31:44
BePC Haiku” on my computer), so the configure script needs to be
modified.
With this patch, sdl treats haiku just like beos. In the future, I
think we should differentiate the platforms, since Haiku is more posix
compatible, and it has some new api.

For the configure script to work properly, you should also include in
the sdl package a more updated config.sub and config.guess from
libtool.

I will also start to port sdl 1.3 to haiku.

The patch is against the svn head.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Stefano,
Have you reviewed the patches we have at HaikuPorts? Perhaps they can
be refined and then merged into one, and then submitted?
http://ports.haiku-files.org/browser/haikuports/trunk/media-libs/libsdl
Seems your patch only touches configure.in, did you make sure the
tests all work? Parts of the patches on HaikuPorts are no longer
needed since Haiku dropped defining BEOS, so those parts need to
be updated.
-scottmc


Hi Scott.

You are right, of course.
I forgot I had BEOS defined in my .profile so the build worked out
of the box.
I haven’t checked the patches on beports yet. I (wrongly) supposed
that if beports had a look at sdl, the patches would have already been
submitted.
Anyway, is there any reason why you didn’t submit the patches yet ?


Good question. Thought I did, so I just looked and looks like I did,
but then forgot about it:
http://bugzilla.libsdl.org/show_bug.cgi?id=615
I’ll take a look at cleaning up the patches and merge them into one
and updating the bugzilla ticket in the next few days here so it can
be added to SDL svn.
-scottmcOn Fri, Feb 27, 2009 at 5:43 AM, Stefano Ceccherini <stefano.ceccherini at gmail.com> wrote:

On Thu, Feb 26, 2009 at 12:49 PM, Stefano Ceccherini <stefano.ceccherini at gmail.com> wrote:

I’ll take a look at cleaning up the patches and merge them into one
and updating the bugzilla ticket in the next few days here so it can
be added to SDL svn.

Great, thanks!

See ya,
-Sam Lantinga, Founder and President, Galaxy Gameworks LLC

Ok. I’ve combined the various Haiku patches for the SDL-1.2 branch
into one .diff file, here’s the url to it:
http://ports.haiku-files.org/browser/haikuports/trunk/media-libs/libsdl/sdl-1.2-haiku.diff?rev=245
At the bottom of the page you can click “original format” to get the
actual file for applying it. This was created with 'svn diff’
This branch could also can use a refresh of the
config.guess/config.sub files. We’ll probably start looking at a
Haiku patch for the SDL-1.3 trunk next, I tried this patch on it and
there’s a few issues, so we’ll iron those out, it looks like you’ve
made some changes to the BeOS code there so we’ll need to see how that
affects things.
The only place in the patch that might have an affect on other systems
is the change to line 43 of configure.in, so you may or may not want
to use that change.
-scottmcOn Fri, Feb 27, 2009 at 1:39 AM, Sam Lantinga wrote:

I’ll take a look at cleaning up the patches and merge them into one
and updating the bugzilla ticket in the next few days here so it can
be added to SDL svn.

Great, thanks!

See ya,
? ? ? ?-Sam Lantinga, Founder and President, Galaxy Gameworks LLC


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Ok, so a couple more changes were made to the patch since I sent it
in. Here’s the latest version, this is for sdl-1.2 svn.
-------------- next part --------------
A non-text attachment was scrubbed…
Name: sdl-1.2-haiku.diff
Type: application/octet-stream
Size: 5749 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20090308/99848734/attachment.obj

Ok, so a couple more changes were made to the patch since I sent it
in. Here’s the latest version, this is for sdl-1.2 svn.

Thanks! Your patch has been applied. :slight_smile:

See ya,
-Sam Lantinga, Founder and President, Galaxy Gameworks LLC