[PATCH] Haptic coding bugs and fixes for Linux FF: periodic.phase handled as time instead of angle; + direction clarification

SDL Development
1

BumpOn Sun, Oct 26, 2014 at 6:06 PM, Sam Lantinga wrote:

Yep, thanks!

On Sun, Oct 26, 2014 at 2:45 AM, Elias Vanderstuyft <@Elias_Vanderstuyft> wrote:

I’m not sure what you mean by “these match the behavior on Mac and
Windows”.
I assume you mean when a SDL periodic.phase of “9000” (= +90deg) is
applied, the behavior is the same across Linux, Mac, and Windows?

They are the same between Mac and Windows, since they essentially use the
same API (based on DInput).
Now the remaining thing to prove, is whether a Linux phase of "0x4000"
corresponds with a DInput phase of “9000”.
If you use FEdit (Microsoft Force Editor), you can see that the DInput
phase is indeed interpreted as a “positive phase”.
For the Linux case, we will standardize the phase as “positive phase”, as
can be seen in QForceStudio (https://github.com/Logitech/qforcestudio).
This means that every Linux FF driver will have to follow this
convention. At the moment, very few Linux FF drivers take the phase
parameter into account,
but this will change in the future (hence the “verification” you asked
for will become a “constraint”).

I hope this answered your question.

Thanks,
Elias

On Sat, Oct 25, 2014 at 9:12 PM, Sam Lantinga wrote:

Have you verified that these match the behavior on Mac and Windows?

Thanks!

On Sat, Oct 25, 2014 at 5:33 AM, Elias Vanderstuyft <@Elias_Vanderstuyft wrote:

Hi all,

Here’s yet another bug report (
https://bugzilla.libsdl.org/show_bug.cgi?id=2766) that handles the
subject of this mail.
You might find the argumentation of the 3rd patch a bit sketchy, but
"we" refers to some people included in Cc.

Thanks,
Elias

2

Looks good. Patches are applied, thanks!On Tue, Nov 25, 2014 at 10:47 AM, Elias Vanderstuyft <elias.vds at gmail.com> wrote:

Bump

On Sun, Oct 26, 2014 at 6:06 PM, Sam Lantinga <@slouken> wrote:

Yep, thanks!

On Sun, Oct 26, 2014 at 2:45 AM, Elias Vanderstuyft <elias.vds at gmail.com> wrote:

I’m not sure what you mean by “these match the behavior on Mac and
Windows”.
I assume you mean when a SDL periodic.phase of “9000” (= +90deg) is
applied, the behavior is the same across Linux, Mac, and Windows?

They are the same between Mac and Windows, since they essentially use
the same API (based on DInput).
Now the remaining thing to prove, is whether a Linux phase of "0x4000"
corresponds with a DInput phase of “9000”.
If you use FEdit (Microsoft Force Editor), you can see that the DInput
phase is indeed interpreted as a “positive phase”.
For the Linux case, we will standardize the phase as “positive phase”,
as can be seen in QForceStudio (https://github.com/Logitech/qforcestudio
).
This means that every Linux FF driver will have to follow this
convention. At the moment, very few Linux FF drivers take the phase
parameter into account,
but this will change in the future (hence the “verification” you asked
for will become a “constraint”).

I hope this answered your question.

Thanks,
Elias

On Sat, Oct 25, 2014 at 9:12 PM, Sam Lantinga <@slouken> wrote:

Have you verified that these match the behavior on Mac and Windows?

Thanks!

On Sat, Oct 25, 2014 at 5:33 AM, Elias Vanderstuyft < elias.vds at gmail.com> wrote:

Hi all,

Here’s yet another bug report (
https://bugzilla.libsdl.org/show_bug.cgi?id=2766) that handles the
subject of this mail.
You might find the argumentation of the 3rd patch a bit sketchy, but
"we" refers to some people included in Cc.

Thanks,
Elias

3

Thanks!

EliasOn Sat, Nov 29, 2014 at 8:52 PM, Sam Lantinga wrote:

Looks good. Patches are applied, thanks!

On Tue, Nov 25, 2014 at 10:47 AM, Elias Vanderstuyft <@Elias_Vanderstuyft> wrote:

Bump

On Sun, Oct 26, 2014 at 6:06 PM, Sam Lantinga wrote:

Yep, thanks!

On Sun, Oct 26, 2014 at 2:45 AM, Elias Vanderstuyft <@Elias_Vanderstuyft wrote:

I’m not sure what you mean by “these match the behavior on Mac and
Windows”.
I assume you mean when a SDL periodic.phase of “9000” (= +90deg) is
applied, the behavior is the same across Linux, Mac, and Windows?

They are the same between Mac and Windows, since they essentially use
the same API (based on DInput).
Now the remaining thing to prove, is whether a Linux phase of "0x4000"
corresponds with a DInput phase of “9000”.
If you use FEdit (Microsoft Force Editor), you can see that the DInput
phase is indeed interpreted as a “positive phase”.
For the Linux case, we will standardize the phase as “positive phase”,
as can be seen in QForceStudio (
https://github.com/Logitech/qforcestudio).
This means that every Linux FF driver will have to follow this
convention. At the moment, very few Linux FF drivers take the phase
parameter into account,
but this will change in the future (hence the “verification” you asked
for will become a “constraint”).

I hope this answered your question.

Thanks,
Elias

On Sat, Oct 25, 2014 at 9:12 PM, Sam Lantinga wrote:

Have you verified that these match the behavior on Mac and Windows?

Thanks!

On Sat, Oct 25, 2014 at 5:33 AM, Elias Vanderstuyft < @Elias_Vanderstuyft> wrote:

Hi all,

Here’s yet another bug report (
https://bugzilla.libsdl.org/show_bug.cgi?id=2766) that handles the
subject of this mail.
You might find the argumentation of the 3rd patch a bit sketchy, but
"we" refers to some people included in Cc.

Thanks,
Elias