[Patch] SDL Linux IBus support

SDL Development
1

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.
-------------- next part --------------
A non-text attachment was scrubbed…
Name: sdl-ibus.diff
Type: text/x-patch
Size: 15580 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20140506/a50d36e2/attachment-0003.bin

2

Here is a second attempt at an IBus IME patch for Linux/X11 platforms.

I’ve updated the patch to allow the --enable-ibus-shared config option,
so that you can compile with or without the dynamic loading, and the
library names are no longer hard coded.

It it still a bit rough around the edges, but any feedback would be welcome.

It’s mirrored on my github now, also:

Alex.On 06/05/14 22:32, Alex Baines wrote:

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

-------------- next part --------------
A non-text attachment was scrubbed…
Name: sdl-ibus2.diff
Type: text/x-patch
Size: 20669 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20140516/3cff8a8d/attachment-0001.bin

3

Just a heads up that I’ve updated this patch again, now it doesn’t have
any dependency on glib (not even dynamically).

I also cleaned the DBus code that was in SDL_x11video.c and moved it to
its own file in src/core/linux, as was suggested by a FIXME.

I’m guessing this might not be the right place to post patches though,
since noone seems to have replied to this thread. If someone could say
where I should be posting this that would be very helpful.

New patch:

Thanks,
Alex Baines.On 16/05/14 22:14, Alex Baines wrote:

Here is a second attempt at an IBus IME patch for Linux/X11 platforms.

I’ve updated the patch to allow the --enable-ibus-shared config option,
so that you can compile with or without the dynamic loading, and the
library names are no longer hard coded.

It it still a bit rough around the edges, but any feedback would be welcome.

It’s mirrored on my github now, also:
https://github.com/baines/SDL-mirror/commit/67a8beff89b7f82fd8d73cd7fd27f49fd51f6d37

Alex.

On 06/05/14 22:32, Alex Baines wrote:

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

4

This is the right place for it, Alex. Just nobody has gotten around
to it just yet.

JosephOn Mon, May 19, 2014 at 12:39:41AM +0100, Alex Baines wrote:

Just a heads up that I’ve updated this patch again, now it doesn’t have
any dependency on glib (not even dynamically).

I also cleaned the DBus code that was in SDL_x11video.c and moved it to
its own file in src/core/linux, as was suggested by a FIXME.

I’m guessing this might not be the right place to post patches though,
since noone seems to have replied to this thread. If someone could say
where I should be posting this that would be very helpful.

New patch:
https://github.com/baines/SDL2-IBus/commit/39eab8eccc28fe7810b4840c0cf1dad44dc03ef9

Thanks,
Alex Baines.

On 16/05/14 22:14, Alex Baines wrote:

Here is a second attempt at an IBus IME patch for Linux/X11 platforms.

I’ve updated the patch to allow the --enable-ibus-shared config option,
so that you can compile with or without the dynamic loading, and the
library names are no longer hard coded.

It it still a bit rough around the edges, but any feedback would be welcome.

It’s mirrored on my github now, also:
https://github.com/baines/SDL-mirror/commit/67a8beff89b7f82fd8d73cd7fd27f49fd51f6d37

Alex.

On 06/05/14 22:32, Alex Baines wrote:

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

5

Offhand, this looks good. Can you submit a bug to bugzilla.libsdl.org and
attach this patch?

Thanks!On Sun, May 18, 2014 at 4:39 PM, Alex Baines wrote:

Just a heads up that I’ve updated this patch again, now it doesn’t have
any dependency on glib (not even dynamically).

I also cleaned the DBus code that was in SDL_x11video.c and moved it to
its own file in src/core/linux, as was suggested by a FIXME.

I’m guessing this might not be the right place to post patches though,
since noone seems to have replied to this thread. If someone could say
where I should be posting this that would be very helpful.

New patch:

https://github.com/baines/SDL2-IBus/commit/39eab8eccc28fe7810b4840c0cf1dad44dc03ef9

Thanks,
Alex Baines.

On 16/05/14 22:14, Alex Baines wrote:

Here is a second attempt at an IBus IME patch for Linux/X11 platforms.

I’ve updated the patch to allow the --enable-ibus-shared config option,
so that you can compile with or without the dynamic loading, and the
library names are no longer hard coded.

It it still a bit rough around the edges, but any feedback would be
welcome.

It’s mirrored on my github now, also:

https://github.com/baines/SDL-mirror/commit/67a8beff89b7f82fd8d73cd7fd27f49fd51f6d37

Alex.

On 06/05/14 22:32, Alex Baines wrote:

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

6

I’ve submitted the patch as a bug report here:

https://bugzilla.libsdl.org/show_bug.cgi?id=2554

It has a few fixes since the last one I posted.

Thanks,
Alex BainesOn 19/05/14 02:20, Sam Lantinga wrote:

Offhand, this looks good. Can you submit a bug to bugzilla.libsdl.org and
attach this patch?

Thanks!

On Sun, May 18, 2014 at 4:39 PM, Alex Baines <@Alex_Baines> wrote:

Just a heads up that I’ve updated this patch again, now it doesn’t have
any dependency on glib (not even dynamically).

I also cleaned the DBus code that was in SDL_x11video.c and moved it to
its own file in src/core/linux, as was suggested by a FIXME.

I’m guessing this might not be the right place to post patches though,
since noone seems to have replied to this thread. If someone could say
where I should be posting this that would be very helpful.

New patch:

https://github.com/baines/SDL2-IBus/commit/39eab8eccc28fe7810b4840c0cf1dad44dc03ef9

Thanks,
Alex Baines.

On 16/05/14 22:14, Alex Baines wrote:

Here is a second attempt at an IBus IME patch for Linux/X11 platforms.

I’ve updated the patch to allow the --enable-ibus-shared config option,
so that you can compile with or without the dynamic loading, and the
library names are no longer hard coded.

It it still a bit rough around the edges, but any feedback would be
welcome.

It’s mirrored on my github now, also:

https://github.com/baines/SDL-mirror/commit/67a8beff89b7f82fd8d73cd7fd27f49fd51f6d37

Alex.

On 06/05/14 22:32, Alex Baines wrote:

Hi,

I saw that there had been some work on incorporating the IBus IME with
SDL2 done last year by emarcotte here:
https://forums.libsdl.org/viewtopic.php?t=9516 .

I have modified the patch so that it dynamically loads libraries as
suggested, and creates a separate GMainContext so that it doesn’t
iterate the default one, as well as a few other changes. The patch is
based on hg changeset 8752:44d31ae3d104.

I’m happy to work on the patch some more if you let me know what bits
should be improved / changed.

Alex.

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org