PULL REQUEST: Android APK expansion files support

Simple patch that adds initial support for android APK expansion files.
Tiny issues is that it depends on “Google Play APK Expansion Library” from
Android SDK Extra. Not sure if it’s ok for SDL. Anyway feel free to share
any your thoughts about this patch. It can be pulled from
https://bitbucket.org/stopiccot/sdl/branch/apk

Regards, Alexey

Getting something in there that enables SDL to handle expansion files would be very useful. (note: I don’t maintain SDL, but I did have to work around the absence of this functionality in SDL recently).

Looking at the code changes, it seems to handle an expansion library that has already been downloaded. There is probably a good discussion about how to put the onus on the SDL user to sync expansion files to Android.

Michael Labb?> On Apr 8, 2014, at 7:34 AM, Alexey Petruchik <alexey.petruchik at gmail.com> wrote:

Simple patch that adds initial support for android APK expansion files. Tiny issues is that it depends on “Google Play APK Expansion Library” from Android SDK Extra. Not sure if it’s ok for SDL. Anyway feel free to share any your thoughts about this patch. It can be pulled from https://bitbucket.org/stopiccot/sdl/branch/apk

Regards, Alexey


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Can you submit this in bugzilla and assign it to me? I’ll make sure to
review it. Thanks!

2014-04-08 11:34 GMT-03:00 Alexey Petruchik <alexey.petruchik at gmail.com>:> Simple patch that adds initial support for android APK expansion files.

Tiny issues is that it depends on “Google Play APK Expansion Library” from
Android SDK Extra. Not sure if it’s ok for SDL. Anyway feel free to share
any your thoughts about this patch. It can be pulled from
https://bitbucket.org/stopiccot/sdl/branch/apk

Regards, Alexey


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Gabriel.

Done. Bug id - 2498On Mon, Apr 14, 2014 at 3:50 PM, Gabriel Jacobo wrote:

Can you submit this in bugzilla and assign it to me? I’ll make sure to
review it. Thanks!

2014-04-08 11:34 GMT-03:00 Alexey Petruchik <@Alexey_Petruchik>:

Simple patch that adds initial support for android APK expansion files.
Tiny issues is that it depends on “Google Play APK Expansion Library” from
Android SDK Extra. Not sure if it’s ok for SDL. Anyway feel free to share
any your thoughts about this patch. It can be pulled from
https://bitbucket.org/stopiccot/sdl/branch/apk

Regards, Alexey


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Gabriel.


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org