Refresh rate patch - worth it?

I quickly hacked SDL to be able to request a specific refresh rate for
the windib driver. It seems to work. The parameter is passed through an
environment variable so there are absolutely no API changes.

The question is, I’ve done this in SDL 1.2 - should I submit a patch? Or
is 1.2 considered legacy already and not worth patching? Or is this
feature useless for everyone except me?

    --Gabriel________________________________________________________________________

Gabriel Gambetta
Mystery Studio

I think having a way for the end-user to select a more ideal refresh
rate than the default could be quite useful. I remember a monitor I
had where at 800x600, the only refresh rate that looked good was 75Hz,
as opposed to the 85Hz that looked good for every other resolution.

In a similar vein, having the end-user be able to override SDL’s
default selection of video-resolution would also be useful. (E.g. many
1280x1024 LCD’s only have square pixels at that single resolution.)
See feature request http://bugzilla.libsdl.org/show_bug.cgi?id=302.
Has anyone looked at how feasible it would be to implement this kind of
overriding in SDL_SetVideoMode?

Anyway I don’t want to hijack the discussion about refresh rates, but
it seems to me that overriding SDL’s selection of refresh rates should
be considered together with an overriding of the video-resolution, so
that the end-user can completely control the screen mode an application
will use.

And I for one would really like to see another 1.2 release with these
features available, i.e. environment variables so the user can ovveride
physical width, physical height, and refresh rate.

Mike

— Gabriel Gambetta wrote:> I quickly hacked SDL to be able to request a specific refresh rate

for
the windib driver. It seems to work. The parameter is passed through
an
environment variable so there are absolutely no API changes.

The question is, I’ve done this in SDL 1.2 - should I submit a patch?
Or
is 1.2 considered legacy already and not worth patching? Or is this
feature useless for everyone except me?

    --Gabriel

Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

2006/9/12, Michael Bandsmer :

And I for one would really like to see another 1.2 release with these
features available, i.e. environment variables so the user can ovveride
physical width, physical height, and refresh rate.

I agree with you completely. 1.2 should not be locked for new features
like these.
But maybe there will be also another way to set refresh rate witout
using environment vars, for example thru SDL_SetVideoModeEx or
something like that.–
Roman Kyrylych (??? ???)

And I for one would really like to see another 1.2 release with these
features available, i.e. environment variables so the user can ovveride
physical width, physical height, and refresh rate.

I’m making a totally unauthorized executive decision here: no more API
changes in 1.2.

Doing so just removes momentum from 1.3, and makes us spend time moving
them back and forth between Subversion trees.

There will definitely be at least one more 1.2 release for bugfixes, and
new video/audio/etc backends and platform ports should probably be
welcomed if they don’t require major surgery to the rest of the library.

1.2 still has legs, as we have a lot of foundational work to do on 1.3
still. But all work on it needs to be support and bugfixing of the
existing codebase.

And naturally, the 1.3 API can still be added to, subtracted from, and
just generally mangled with reckless abandon (well, okay, okay: added
to!) … discussions on new features should really happen there.

–ryan.

And I for one would really like to see another 1.2 release with these
features available, i.e. environment variables so the user can ovveride
physical width, physical height, and refresh rate.

I’m making a totally unauthorized executive decision here: no more API
changes in 1.2.

Hear hear!

In case you don’t know, all these features and more are already in the 1.3
preview snapshot: http://www.libsdl.org/tmp/SDL-1.3.zip

See ya,
-Sam Lantinga, Senior Software Engineer, Blizzard Entertainment

I quickly hacked SDL to be able to request a specific refresh rate for
the windib driver. It seems to work. The parameter is passed through an
environment variable so there are absolutely no API changes.

The question is, I’ve done this in SDL 1.2 - should I submit a patch? Or
is 1.2 considered legacy already and not worth patching? Or is this
feature useless for everyone except me?

To answer your question, feel free to post a link to a patch. It won’t
be included in the official SDL releases, but I’m guessing lots of people
will appreciate it.

Also, if you have time, I’d be curious on your feedback on the SDL 1.3
snapshot I mentioned earlier, as well as checking out it’s 1.2 compatibility
for your application.

Thanks!
-Sam Lantinga, Senior Software Engineer, Blizzard Entertainment