SDL: Fixed error message when trying to create an OpenGLES2 renderer on macOS

From 913e403f2aa5a23beee878b6b13f7603b884c18a Mon Sep 17 00:00:00 2001
From: Sam Lantinga <[EMAIL REDACTED]>
Date: Wed, 16 Nov 2022 18:03:29 -0800
Subject: [PATCH] Fixed error message when trying to create an OpenGLES2
 renderer on macOS

Testing: testsprite2 --renderer opengles2

OpenGLES2 isn't available by default, and we want to see the error "Could not load EGL library"
---
 src/video/cocoa/SDL_cocoawindow.m | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/video/cocoa/SDL_cocoawindow.m b/src/video/cocoa/SDL_cocoawindow.m
index ddf2fc9f55f6..c73827656810 100644
--- a/src/video/cocoa/SDL_cocoawindow.m
+++ b/src/video/cocoa/SDL_cocoawindow.m
@@ -2274,7 +2274,9 @@ - (BOOL)acceptsFirstMouse:(NSEvent *)theEvent
 
     /* Not recognized via CHECK_WINDOW_MAGIC */
     if (data == nil) {
-        return SDL_SetError("Window data not set");
+        /* Don't set the error here, it hides other errors and is ignored anyway */
+        /*return SDL_SetError("Window data not set");*/
+        return -1;
     }
 
     /* NSWindow.screen may be nil when the window is off-screen. */