From 90262f274ab73a2a0db227f8a1a3ea823ba0faec Mon Sep 17 00:00:00 2001
From: Sam Lantinga <[EMAIL REDACTED]>
Date: Mon, 3 Jul 2023 17:37:17 -0700
Subject: [PATCH] Made error handling more consistent in
D3D12_RenderReadPixels()
---
src/render/direct3d12/SDL_render_d3d12.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/render/direct3d12/SDL_render_d3d12.c b/src/render/direct3d12/SDL_render_d3d12.c
index 16fcb5ee3d06..43ce78b4c2e0 100644
--- a/src/render/direct3d12/SDL_render_d3d12.c
+++ b/src/render/direct3d12/SDL_render_d3d12.c
@@ -2832,8 +2832,8 @@ static int D3D12_RenderReadPixels(SDL_Renderer *renderer, const SDL_Rect *rect,
NULL,
(void **)&textureMemory);
if (FAILED(result)) {
- SAFE_RELEASE(readbackBuffer);
- return WIN_SetErrorFromHRESULT(SDL_COMPOSE_ERROR("ID3D12Resource::Map [map staging texture]"), result);
+ WIN_SetErrorFromHRESULT(SDL_COMPOSE_ERROR("ID3D12Resource::Map [map staging texture]"), result);
+ goto done;
}
/* Copy the data into the desired buffer, converting pixels to the