# SDL: Reverted game controller buttons from interacting with message box dialogs

**URL:** <https://discourse.libsdl.org/t/sdl-reverted-game-controller-buttons-from-interacting-with-message-box-dialogs/39172>\
**Category:** SDL Commits\
**Created:** [October 6, 2022, 7:10pm UTC](https://discourse.libsdl.org/t/sdl-reverted-game-controller-buttons-from-interacting-with-message-box-dialogs/39172 "2022-10-06T19:10:09Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![SDLPushPostBot](https://discourse.libsdl.org/user_avatar/discourse.libsdl.org/sdlpushpostbot/32/4370_2.png) [@SDLPushPostBot](https://discourse.libsdl.org/u/SDLPushPostBot)\
**Post date:** [October 6, 2022, 7:10pm UTC](https://discourse.libsdl.org/t/sdl-reverted-game-controller-buttons-from-interacting-with-message-box-dialogs/39172/1 "2022-10-06T19:10:09Z")

</div>

> <https://github.com/libsdl-org/SDL/commit/b4aba10154f901fc36af0fb94742201c21ce7f74>
>
> These would only work for non-HIDAPI controllers, and other controller input wou…ld leak past the dialog, both of which would be confusing.

```diff
From b4aba10154f901fc36af0fb94742201c21ce7f74 Mon Sep 17 00:00:00 2001
From: Sam Lantinga <[EMAIL REDACTED]>
Date: Thu, 6 Oct 2022 12:10:46 -0700
Subject: [PATCH] Reverted game controller buttons from interacting with
 message box dialogs

These would only work for non-HIDAPI controllers, and other controller input would leak past the dialog, both of which would be confusing.
---
 .../app/src/main/java/org/libsdl/app/SDLActivity.java | 2 --
 1 file changed, 2 deletions(-)

diff --git a/android-project/app/src/main/java/org/libsdl/app/SDLActivity.java b/android-project/app/src/main/java/org/libsdl/app/SDLActivity.java
index e44cc2d4ea22..666ea3164df3 100644
--- a/android-project/app/src/main/java/org/libsdl/app/SDLActivity.java
+++ b/android-project/app/src/main/java/org/libsdl/app/SDLActivity.java
@@ -1556,11 +1556,9 @@ public void onClick(View v) {
                 // see SDL_messagebox.h
                 if ((buttonFlags[i] & 0x00000001) != 0) {
                     mapping.put(KeyEvent.KEYCODE_ENTER, button);
- mapping.put(KeyEvent.KEYCODE_BUTTON_A, button);
                 }
                 if ((buttonFlags[i] & 0x00000002) != 0) {
                     mapping.put(KeyEvent.KEYCODE_ESCAPE, button); /* API 11 */
- mapping.put(KeyEvent.KEYCODE_BUTTON_B, button);
                 }
             }
             button.setText(buttonTexts[i]);

```