this fixes the pitch versus width difference that can happen
(especially for 8bit and 24bit (with the exact RGBAmasks) surfaces)
when you use SDL_SaveBMP. The problem was the pitch was used
instead of the width, which in some cases is much wider than the
screen area you really want to save…making for ugly crud on the
saved image borders.
This code has been tested with & without pitch overhangs…and
with the right masks for 24 bit surfaces.
I tested 8,15,16,24,32-0RGB,32-RGBA(with no SDL_SRCALPHA flag).
if anyone wants the modified testpalette.c that I used, email me.
-LIM-
-------------------patch-------------------------------------------
Index: src/video/SDL_bmp.c===================================================================
RCS file: /home/sdlweb/libsdl.org/cvs/SDL12/src/video/SDL_bmp.c,v
retrieving revision 1.5
diff -u -b -B -r1.5 SDL_bmp.c
— src/video/SDL_bmp.c 4 Jan 2004 16:49:21 -0000 1.5
+++ src/video/SDL_bmp.c 14 Dec 2004 02:16:33 -0000
@@ -413,6 +413,7 @@
}
if ( surface && (SDL_LockSurface(surface) == 0) ) {
-
const int bw = surface->w*surface->format->BytesPerPixel; /* Set the BMP file header values */ bfSize = 0; /* We'll write this when we're done */ bfReserved1 = 0;
@@ -485,11 +486,11 @@
/* Write the bitmap image upside down */
bits = (Uint8 *)surface->pixels+(surface->h*surface->pitch);
-
pad = ((surface->pitch%4) ? (4-(surface->pitch%4)) : 0);
-
pad = ((bw%4) ? (4-(bw%4)) : 0); while ( bits > (Uint8 *)surface->pixels ) { bits -= surface->pitch;
-
if ( SDL_RWwrite(dst, bits, 1, surface->pitch) -
!= surface->pitch) {
-
if ( SDL_RWwrite(dst, bits, 1, bw) -
!= bw) { SDL_Error(SDL_EFWRITE); break; }