From ec3d9421e7a4f5b16d7650ae2608054459015d75 Mon Sep 17 00:00:00 2001
From: "Ryan C. Gordon" <[EMAIL REDACTED]>
Date: Tue, 30 Aug 2022 23:45:43 -0400
Subject: [PATCH] FIXME removal: Give up on SDL 1.2 SDLK_(COMPOSE|BREAK|EURO)
keycodes.
SDLK_COMPOSE was only referenced in the x11 backend, as a sort of "I have
nothing better to assign to this random set of keys." SDLK_BREAK is generally
the same key as SDLK_PAUSE. SDLK_EURO appears to only be used by the 1.2
BeOS backend, and The Be Book can't identify a physical key that generates
this keycode:
https://www.haiku-os.org/legacy-docs/bebook/TheKeyboard_KeyCodes.html
So nothing reasonable maps to these things (and if they _are_ reasonable,
SDL2 doesn't report anything equivalent to them), so in the best case they
aren't goign concerns, in the worst case we just pretend the user never
pressed them.
So the FIXME is simply removed.
Reference Issue #143.
---
src/SDL12_compat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/SDL12_compat.c b/src/SDL12_compat.c
index 9ef44c14..82085ce3 100644
--- a/src/SDL12_compat.c
+++ b/src/SDL12_compat.c
@@ -3951,7 +3951,6 @@ Keysym20to12(const SDL_Keycode keysym20)
default: break;
}
- FIXME("nothing maps to SDLK12_COMPOSE, SDLK12_BREAK, or SDLK12_EURO ...?");
return SDLK12_UNKNOWN;
}
static SDL12Key