From 3d3401858a11caf2c4203935144897ef0d08e1ed Mon Sep 17 00:00:00 2001
From: "Ryan C. Gordon" <[EMAIL REDACTED]>
Date: Thu, 18 Aug 2022 16:54:21 -0400
Subject: [PATCH] FIXME removal: take out notes about bgr vs rgb.
This was wondering if using BGR pixel layout would be more
correct/efficient, but honestly it's not hurting anything as it
is now, so I'm just deleting the FIXMEs.
Reference Issue #143.
---
src/SDL12_compat.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/SDL12_compat.c b/src/SDL12_compat.c
index 91029c91..6948e8d4 100644
--- a/src/SDL12_compat.c
+++ b/src/SDL12_compat.c
@@ -5639,9 +5639,9 @@ SDL_SetVideoMode(int width, int height, int bpp, Uint32 flags12)
#endif
switch (bpp) {
case 8: appfmt = SDL_PIXELFORMAT_INDEX8; break;
- case 16: appfmt = SDL_PIXELFORMAT_RGB565; FIXME("bgr instead of rgb?"); break;
- case 24: appfmt = SDL_PIXELFORMAT_RGB888; FIXME("bgr instead of rgb?"); break;
- case 32: appfmt = SDL_PIXELFORMAT_XRGB8888; FIXME("bgr instead of rgb?"); break;
+ case 16: appfmt = SDL_PIXELFORMAT_RGB565; break;
+ case 24: appfmt = SDL_PIXELFORMAT_RGB888; break;
+ case 32: appfmt = SDL_PIXELFORMAT_XRGB8888; break;
default: SDL20_SetError("Unsupported bits-per-pixel"); return NULL;
}
@@ -6222,7 +6222,7 @@ SDL_DisplayFormatAlpha(SDL12_Surface *surface12)
}
/* we only allow a few formats for the screen surface, and this is the appropriate alpha format for all of them. */
- fmt20 = SDL20_AllocFormat(SDL_PIXELFORMAT_ARGB8888); FIXME("bgr instead of rgb?");
+ fmt20 = SDL20_AllocFormat(SDL_PIXELFORMAT_ARGB8888);
if (!fmt20) {
return NULL;
}