From d7ce2ec90fc2482c3e60c1c84bc59c864805450c Mon Sep 17 00:00:00 2001
From: David Gow <[EMAIL REDACTED]>
Date: Tue, 8 Jun 2021 17:40:19 +0800
Subject: [PATCH] testloadso: Actually return an error if one occurs
The 'retval' value used to track what exit code the test app should
return is never actually used. Instead 0 (success) is returned
unconditionally, which can cause the program to appear as though it
succeded (at least to a script which doesn't check the text output).
This was caught by an unusued variable warning in gcc, and appears to be
an actual bug, rather than just a useless variable.
---
test/testloadso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/testloadso.c b/test/testloadso.c
index 39c14c6..802a508 100644
--- a/test/testloadso.c
+++ b/test/testloadso.c
@@ -65,7 +65,7 @@ int main(int argc, char *argv[])
SDL_UnloadObject(lib);
}
SDL_Quit();
- return(0);
+ return retval;
}