From 3e675d1b3194aacff175a7288257a95e8edb2400 Mon Sep 17 00:00:00 2001
From: "Ryan C. Gordon" <[EMAIL REDACTED]>
Date: Mon, 14 Aug 2023 20:09:39 -0400
Subject: [PATCH] github-webhook: note errors in writing to log files.
---
github-webhook/index.php | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/github-webhook/index.php b/github-webhook/index.php
index adde94a..3543d62 100644
--- a/github-webhook/index.php
+++ b/github-webhook/index.php
@@ -78,7 +78,8 @@ function validateSignature($gitHubSignatureHeader, $payload)
$fnameid++;
} while (($fp = @fopen($fname, 'x')) === false); // 'x' so we make sure other hook handlers don't compete for the file name.
- fwrite($fp, $payload);
+ $payloadlen = strlen($payload);
+ $bw = fwrite($fp, $payload, $payloadlen);
fclose($fp);
if ($lockfp !== false) {
@@ -86,7 +87,11 @@ function validateSignature($gitHubSignatureHeader, $payload)
fclose($lockfp);
}
- print("PUSH INFO SAVED TO: $fname\n");
+ if (($bw === false) || ($bw != $payloadlen)) {
+ print("FAILED TO WRITE FULLY TO '$fname': (bw=$bw)\n");
+ } else {
+ print("PUSH INFO SAVED TO: $fname\n");
+ }
}
if ($repo == 'sdlweb') {