Who will accept patches to SDL_mixer to add support for libmad?

Greetings!

It was recently necessary for me to add code to SDL_mixer to support
libmad for mp3 playback in addition to smpeg.

I needed libmad because I am working on porting a program to the GP2x
handheld device ( http://gp2x.co.uk/ ), which does not have a
floating-point unit, so the floating-point calculations performed by
smpeg must be emulated in software and are therefore unacceptably
expensive. libmad, on the other hand, was written specifically for
architectures that lack a floating-point unit, and it performs quite
well on the GP2x.

There may also be reasons to prefer libmad on a standard platform such
as a PC, but this decision may be left to the end-user. I have designed
my patches such that it is an optional feature that may be enabled at
configure time; it need not replace the existing smpeg support.

I have patches against SDL_mixer version 1.2.7 (as well as against
version 1.2.6). Would anyone appreciate receiving this contribution to
the codebase?

David

I have patches against SDL_mixer version 1.2.7 (as well as against
version 1.2.6). Would anyone appreciate receiving this contribution to
the codebase?

Sure! Go ahead and enter it as an enhancement in SDL bugzilla:
http://bugzilla.libsdl.org/

Thanks!
-Sam Lantinga, Senior Software Engineer, Blizzard Entertainment

I have patches against SDL_mixer version 1.2.7 (as well as against
version 1.2.6). Would anyone appreciate receiving this contribution to
the codebase?

libmad is GPL’d. We cannot include it in a LGPL’d library.

–ryan.

We don’t need to include libmad with SDL. I am only adding patches that
allow SDL_mixer to be optionally built with libmad.

If the user is developing a GPL application, he can certainly choose to
compile a version of SDL that uses libmad, and then use that in his
application.

David

Ryan C. Gordon wrote:

I have patches against SDL_mixer version 1.2.7 (as well as against
version 1.2.6). Would anyone appreciate receiving this contribution to
the codebase?

libmad is GPL’d. We cannot include it in a LGPL’d library.

–ryan.


SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl
-------------- next part --------------
A non-text attachment was scrubbed…
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3166 bytes
Desc: S/MIME Cryptographic Signature
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20060630/5294b910/attachment.bin

We don’t need to include libmad with SDL. I am only adding patches that
allow SDL_mixer to be optionally built with libmad.

That’s fine, as long as the default is not to build with libmad support.
We don’t want to accidentally release a binary that is linked with it.

-Sam Lantinga, Senior Software Engineer, Blizzard Entertainment