From e7d3616e1a58817667bd02cd08b0148a5b3028a4 Mon Sep 17 00:00:00 2001
From: Ozkan Sezer <[EMAIL REDACTED]>
Date: Tue, 24 Oct 2023 03:45:28 +0300
Subject: [PATCH] remove __cplusplus and BLARGG_BUILD_DLL conditions from
debug_printf macro
as discussed at https://github.com/libgme/game-music-emu/commit/cdf332f29c719a672920b869680a481a23ade83b#r130740171
---
gme/CMakeLists.txt | 8 +-------
gme/blargg_source.h | 8 +++-----
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/gme/CMakeLists.txt b/gme/CMakeLists.txt
index fb79cc6..c64a040 100644
--- a/gme/CMakeLists.txt
+++ b/gme/CMakeLists.txt
@@ -184,14 +184,8 @@ set_property(TARGET gme PROPERTY CXX_VISIBILITY_PRESET "hidden")
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
target_compile_definitions(gme PRIVATE LIBGME_VISIBILITY)
endif()
-
-# On some platforms we may need to change headers or whatnot based on whether
-# we're building the library or merely using the library. The following is
-# only defined when building the library to allow us to tell which is which.
-if(BUILD_SHARED_LIBS)
+if(WIN32)
set_property(TARGET gme PROPERTY DEFINE_SYMBOL BLARGG_BUILD_DLL)
-else()
- target_compile_definitions(gme PRIVATE -DBLARGG_BUILD_DLL)
endif()
target_compile_definitions(gme PRIVATE GEN_TYPES_H)
diff --git a/gme/blargg_source.h b/gme/blargg_source.h
index d03b094..8f20d5d 100644
--- a/gme/blargg_source.h
+++ b/gme/blargg_source.h
@@ -34,11 +34,9 @@
/* Like printf() except output goes to debug log file. Might be defined to do
* nothing (not even evaluate its arguments).
* void debug_printf( const char* format, ... ); */
-#if defined(__cplusplus) && defined(BLARGG_BUILD_DLL)
- static inline void blargg_dprintf_( const char* fmt_str, ... ) { (void) fmt_str; }
- #undef debug_printf
- #define debug_printf (1) ? (void) 0 : blargg_dprintf_
-#endif
+static inline void blargg_dprintf_( const char* fmt_str, ... ) { (void) fmt_str; }
+#undef debug_printf
+#define debug_printf (1) ? (void) 0 : blargg_dprintf_
/* If enabled, evaluate expr and if false, make debug log entry with source file
* and line. Meant for finding situations that should be examined further, but that