MacOS LockAudio patch, take 2:

SDL Development
21

Hmmm … Actually, is your phone number 95303410?

I suggest you change your phone number now! HAHAHAHAH> If it isn’t, you won’t get a call from me, and had better call

instead :slight_smile:

----- Original Message -----
From: “Sam Lantinga”
To:
Sent: Sunday, March 31, 2002 7:46 AM
Subject: Re: [SDL] MacOS LockAudio patch, take 2:

There’s a race condition in your SDL_mixer patch.

Step 1. The mixer callback runs, setting in_mixer_callback to 1.
Step 2. The app code runs, sees in_mixer_callback, and doesn’t lock
audio

Step 3. Both the mixer and the app are stomping on effects data. :slight_smile:

What you probably want to do is pass a parameter to an internal
function

and call that with in_mixer == false from the API function.

Maybe I’m confused here, but I think that this can’t happen because
the
app can’t preempt the callback (On OS 9, on OS X it can).

This is not a Mac-specific comment - it deals with any of the SDL audio
implementations.

I forgot about this point in my previous message, we should keep using
the mutexes for Mac OS X unless you’ve already changed the code to
remedy

this.

Erm… Ryan? Should we use the default lock/unlock calls on MacOS X?

-Sam Lantinga, Software Engineer, Blizzard Entertainment

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl

22

Got in about half an hour ago, and had a minor emergency when I found out
that Rocket Rat had escaped somewhere. Found her eventually snuggled up
peacefully in the bottom of the sock drawer.

God, that’s the funniest thing I’ve read in a while. :slight_smile:

–ryan.

23

lol

Thank god the phonen number was wrong anyway.> ----- Original Message -----

From: leimbacd@bellsouth.net (David Leimbach)
To:
Sent: Sunday, March 31, 2002 10:50 AM
Subject: Re: [SDL] MacOS LockAudio patch, take 2:

Hmmm … Actually, is your phone number 95303410?

I suggest you change your phone number now! HAHAHAHAH

If it isn’t, you won’t get a call from me, and had better call
instead :slight_smile:

----- Original Message -----
From: “Sam Lantinga”
To:
Sent: Sunday, March 31, 2002 7:46 AM
Subject: Re: [SDL] MacOS LockAudio patch, take 2:

There’s a race condition in your SDL_mixer patch.

Step 1. The mixer callback runs, setting in_mixer_callback to 1.
Step 2. The app code runs, sees in_mixer_callback, and doesn’t lock
audio

Step 3. Both the mixer and the app are stomping on effects data. :slight_smile:

What you probably want to do is pass a parameter to an internal
function

and call that with in_mixer == false from the API function.

Maybe I’m confused here, but I think that this can’t happen because
the
app can’t preempt the callback (On OS 9, on OS X it can).

This is not a Mac-specific comment - it deals with any of the SDL audio
implementations.

I forgot about this point in my previous message, we should keep using
the mutexes for Mac OS X unless you’ve already changed the code to
remedy

this.

Erm… Ryan? Should we use the default lock/unlock calls on MacOS X?

-Sam Lantinga, Software Engineer, Blizzard Entertainment

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl