From 6d5592a2018990235471d15de65245348710eade Mon Sep 17 00:00:00 2001
From: pionere <[EMAIL REDACTED]>
Date: Sat, 5 Feb 2022 12:02:54 +0100
Subject: [PATCH] minor cleanup of SDL_CreateRenderer
---
src/render/SDL_render.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c
index c2f100ac661..f9f01fb99b9 100644
--- a/src/render/SDL_render.c
+++ b/src/render/SDL_render.c
@@ -930,7 +930,7 @@ SDL_CreateRenderer(SDL_Window * window, int index, Uint32 flags)
#endif
if (!window) {
- SDL_SetError("Invalid window");
+ SDL_InvalidParamError("window");
goto error;
}
@@ -979,24 +979,24 @@ SDL_CreateRenderer(SDL_Window * window, int index, Uint32 flags)
}
}
}
- if (index == n) {
+ if (!renderer) {
SDL_SetError("Couldn't find matching render driver");
goto error;
}
} else {
- if (index >= SDL_GetNumRenderDrivers()) {
+ if (index >= n) {
SDL_SetError("index must be -1 or in the range of 0 - %d",
- SDL_GetNumRenderDrivers() - 1);
+ n - 1);
goto error;
}
/* Create a new renderer instance */
renderer = render_drivers[index]->CreateRenderer(window, flags);
batching = SDL_FALSE;
+ if (!renderer) {
+ goto error;
+ }
}
- if (!renderer) {
- goto error;
- }
VerifyDrawQueueFunctions(renderer);