From 020fb6889ccb5a8ac7e6b16e375de935514f09a6 Mon Sep 17 00:00:00 2001
From: Petar Popovic <[EMAIL REDACTED]>
Date: Thu, 3 Oct 2024 20:19:18 +0200
Subject: [PATCH] Removed unnecessary const-qualifiers in src and test files
---
src/core/linux/SDL_dbus.c | 4 ++--
src/core/linux/SDL_dbus.h | 4 ++--
src/dialog/SDL_dialog_utils.c | 2 +-
src/dialog/SDL_dialog_utils.h | 2 +-
src/events/SDL_keyboard.c | 2 +-
src/events/SDL_keyboard_c.h | 2 +-
src/render/SDL_render.c | 2 +-
src/render/SDL_sysrender.h | 2 +-
src/stdlib/SDL_string.c | 2 +-
src/stdlib/SDL_sysstdlib.h | 2 +-
src/video/x11/SDL_x11pen.c | 2 +-
src/video/x11/SDL_x11pen.h | 2 +-
test/testaudio.c | 4 ++--
13 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/core/linux/SDL_dbus.c b/src/core/linux/SDL_dbus.c
index 371e16e0a4a0f..e3f132d8658d4 100644
--- a/src/core/linux/SDL_dbus.c
+++ b/src/core/linux/SDL_dbus.c
@@ -341,7 +341,7 @@ bool SDL_DBus_CallVoidMethod(const char *node, const char *path, const char *int
return result;
}
-bool SDL_DBus_QueryPropertyOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *property, const int expectedtype, void *result)
+bool SDL_DBus_QueryPropertyOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *property, int expectedtype, void *result)
{
bool retval = false;
@@ -358,7 +358,7 @@ bool SDL_DBus_QueryPropertyOnConnection(DBusConnection *conn, const char *node,
return retval;
}
-bool SDL_DBus_QueryProperty(const char *node, const char *path, const char *interface, const char *property, const int expectedtype, void *result)
+bool SDL_DBus_QueryProperty(const char *node, const char *path, const char *interface, const char *property, int expectedtype, void *result)
{
return SDL_DBus_QueryPropertyOnConnection(dbus.session_conn, node, path, interface, property, expectedtype, result);
}
diff --git a/src/core/linux/SDL_dbus.h b/src/core/linux/SDL_dbus.h
index 45da4e160e33c..55fb8ac7a2daa 100644
--- a/src/core/linux/SDL_dbus.h
+++ b/src/core/linux/SDL_dbus.h
@@ -94,12 +94,12 @@ extern SDL_DBusContext *SDL_DBus_GetContext(void);
// These use the built-in Session connection.
extern bool SDL_DBus_CallMethod(const char *node, const char *path, const char *interface, const char *method, ...);
extern bool SDL_DBus_CallVoidMethod(const char *node, const char *path, const char *interface, const char *method, ...);
-extern bool SDL_DBus_QueryProperty(const char *node, const char *path, const char *interface, const char *property, const int expectedtype, void *result);
+extern bool SDL_DBus_QueryProperty(const char *node, const char *path, const char *interface, const char *property, int expectedtype, void *result);
// These use whatever connection you like.
extern bool SDL_DBus_CallMethodOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *method, ...);
extern bool SDL_DBus_CallVoidMethodOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *method, ...);
-extern bool SDL_DBus_QueryPropertyOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *property, const int expectedtype, void *result);
+extern bool SDL_DBus_QueryPropertyOnConnection(DBusConnection *conn, const char *node, const char *path, const char *interface, const char *property, int expectedtype, void *result);
extern void SDL_DBus_ScreensaverTickle(void);
extern bool SDL_DBus_ScreensaverInhibit(bool inhibit);
diff --git a/src/dialog/SDL_dialog_utils.c b/src/dialog/SDL_dialog_utils.c
index e031721ce0eab..ef3fbdf297641 100644
--- a/src/dialog/SDL_dialog_utils.c
+++ b/src/dialog/SDL_dialog_utils.c
@@ -97,7 +97,7 @@ char *convert_filters(const SDL_DialogFileFilter *filters, int nfilters,
return combined;
}
-char *convert_filter(const SDL_DialogFileFilter filter, NameTransform ntf,
+char *convert_filter(SDL_DialogFileFilter filter, NameTransform ntf,
const char *prefix, const char *separator,
const char *suffix, const char *ext_prefix,
const char *ext_separator, const char *ext_suffix)
diff --git a/src/dialog/SDL_dialog_utils.h b/src/dialog/SDL_dialog_utils.h
index 6c5a77df10df1..1fd71befe2c71 100644
--- a/src/dialog/SDL_dialog_utils.h
+++ b/src/dialog/SDL_dialog_utils.h
@@ -41,7 +41,7 @@ char *convert_filters(const SDL_DialogFileFilter *filters, int nfilters,
// Converts one filter into a single string.
// <prefix>[filter name]<separator>[filter extension list]<suffix>
-char *convert_filter(const SDL_DialogFileFilter filter, NameTransform ntf,
+char *convert_filter(SDL_DialogFileFilter filter, NameTransform ntf,
const char *prefix, const char *separator,
const char *suffix, const char *ext_prefix,
const char *ext_separator, const char *ext_suffix);
diff --git a/src/events/SDL_keyboard.c b/src/events/SDL_keyboard.c
index 2e7dcb839a2fd..438311ba4d453 100644
--- a/src/events/SDL_keyboard.c
+++ b/src/events/SDL_keyboard.c
@@ -888,7 +888,7 @@ void SDL_SetModState(SDL_Keymod modstate)
}
// Note that SDL_ToggleModState() is not a public API. SDL_SetModState() is.
-void SDL_ToggleModState(const SDL_Keymod modstate, const bool toggle)
+void SDL_ToggleModState(SDL_Keymod modstate, bool toggle)
{
SDL_Keyboard *keyboard = &SDL_keyboard;
if (toggle) {
diff --git a/src/events/SDL_keyboard_c.h b/src/events/SDL_keyboard_c.h
index cf4662c8e0b5f..4023822facbb1 100644
--- a/src/events/SDL_keyboard_c.h
+++ b/src/events/SDL_keyboard_c.h
@@ -82,6 +82,6 @@ extern void SDL_SendEditingTextCandidates(char **candidates, int num_candidates,
extern void SDL_QuitKeyboard(void);
// Toggle on or off pieces of the keyboard mod state.
-extern void SDL_ToggleModState(const SDL_Keymod modstate, const bool toggle);
+extern void SDL_ToggleModState(SDL_Keymod modstate, bool toggle);
#endif // SDL_keyboard_c_h_
diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c
index 5b0bf8a89a524..4d3ad518913c2 100644
--- a/src/render/SDL_render.c
+++ b/src/render/SDL_render.c
@@ -354,7 +354,7 @@ bool SDL_FlushRenderer(SDL_Renderer *renderer)
return true;
}
-void *SDL_AllocateRenderVertices(SDL_Renderer *renderer, const size_t numbytes, const size_t alignment, size_t *offset)
+void *SDL_AllocateRenderVertices(SDL_Renderer *renderer, size_t numbytes, size_t alignment, size_t *offset)
{
const size_t needed = renderer->vertex_data_used + numbytes + alignment;
const size_t current_offset = renderer->vertex_data_used;
diff --git a/src/render/SDL_sysrender.h b/src/render/SDL_sysrender.h
index a6320b255b640..91118b8455307 100644
--- a/src/render/SDL_sysrender.h
+++ b/src/render/SDL_sysrender.h
@@ -359,7 +359,7 @@ extern SDL_BlendOperation SDL_GetBlendModeAlphaOperation(SDL_BlendMode blendMode
/* drivers call this during their Queue*() methods to make space in a array that are used
for a vertex buffer during RunCommandQueue(). Pointers returned here are only valid until
the next call, because it might be in an array that gets realloc()'d. */
-extern void *SDL_AllocateRenderVertices(SDL_Renderer *renderer, const size_t numbytes, const size_t alignment, size_t *offset);
+extern void *SDL_AllocateRenderVertices(SDL_Renderer *renderer, size_t numbytes, size_t alignment, size_t *offset);
// Let the video subsystem destroy a renderer without making its pointer invalid.
extern void SDL_DestroyRendererWithoutFreeing(SDL_Renderer *renderer);
diff --git a/src/stdlib/SDL_string.c b/src/stdlib/SDL_string.c
index a7cb691f7c572..03ed3c13ac5e3 100644
--- a/src/stdlib/SDL_string.c
+++ b/src/stdlib/SDL_string.c
@@ -79,7 +79,7 @@ char *SDL_UCS4ToUTF8(Uint32 codepoint, char *dst)
// this expects `from` and `to` to be UTF-32 encoding!
-int SDL_CaseFoldUnicode(const Uint32 from, Uint32 *to)
+int SDL_CaseFoldUnicode(Uint32 from, Uint32 *to)
{
// !!! FIXME: since the hashtable is static, maybe we should binary
// !!! FIXME: search it instead of walking the whole bucket.
diff --git a/src/stdlib/SDL_sysstdlib.h b/src/stdlib/SDL_sysstdlib.h
index 305fd31d304ec..d5de2b8e8a3b6 100644
--- a/src/stdlib/SDL_sysstdlib.h
+++ b/src/stdlib/SDL_sysstdlib.h
@@ -26,7 +26,7 @@
// just a few special pieces right now.
// this expects `from` to be a Unicode codepoint, and `to` to point to AT LEAST THREE Uint32s.
-int SDL_CaseFoldUnicode(const Uint32 from, Uint32 *to);
+int SDL_CaseFoldUnicode(Uint32 from, Uint32 *to);
#endif
diff --git a/src/video/x11/SDL_x11pen.c b/src/video/x11/SDL_x11pen.c
index a6fb1562c81e8..2a78ee99e181a 100644
--- a/src/video/x11/SDL_x11pen.c
+++ b/src/video/x11/SDL_x11pen.c
@@ -402,7 +402,7 @@ static void X11_XInput2NormalizePenAxes(const X11_PenHandle *pen, float *coords)
}
void X11_PenAxesFromValuators(const X11_PenHandle *pen,
- const double *input_values, const unsigned char *mask, const int mask_len,
+ const double *input_values, const unsigned char *mask, int mask_len,
float axis_values[SDL_PEN_AXIS_COUNT])
{
for (int i = 0; i < SDL_PEN_AXIS_COUNT; i++) {
diff --git a/src/video/x11/SDL_x11pen.h b/src/video/x11/SDL_x11pen.h
index b15d2a2dc2cae..365940ee4f8a0 100644
--- a/src/video/x11/SDL_x11pen.h
+++ b/src/video/x11/SDL_x11pen.h
@@ -55,7 +55,7 @@ typedef struct X11_PenHandle
// Converts XINPUT2 valuators into pen axis information, including normalisation.
extern void X11_PenAxesFromValuators(const X11_PenHandle *pen,
- const double *input_values, const unsigned char *mask, const int mask_len,
+ const double *input_values, const unsigned char *mask, int mask_len,
float axis_values[SDL_PEN_AXIS_COUNT]);
// Add a pen (if this function's further checks validate it).
diff --git a/test/testaudio.c b/test/testaudio.c
index 7eb6e75c1b6ee..49dbfb3c8c074 100644
--- a/test/testaudio.c
+++ b/test/testaudio.c
@@ -731,7 +731,7 @@ static Texture *CreateTexture(const char *fname)
return tex;
}
-static Thing *CreateLogicalDeviceThing(Thing *parent, const SDL_AudioDeviceID which, const float x, const float y);
+static Thing *CreateLogicalDeviceThing(Thing *parent, SDL_AudioDeviceID which, float x, float y);
static void DeviceThing_ondrag(Thing *thing, int button, float x, float y)
{
@@ -903,7 +903,7 @@ static void LogicalDeviceThing_onmousewheel(Thing *thing, float y)
SDL_SetAudioDeviceGain(thing->data.logdev.devid, thing->meter);
}
-static Thing *CreateLogicalDeviceThing(Thing *parent, const SDL_AudioDeviceID which, const float x, const float y)
+static Thing *CreateLogicalDeviceThing(Thing *parent, SDL_AudioDeviceID which, float x, float y)
{
static const ThingType can_be_dropped_onto[] = { THING_TRASHCAN, THING_NULL };
Thing *physthing = ((parent->what == THING_LOGDEV) || (parent->what == THING_LOGDEV_RECORDING)) ? parent->data.logdev.physdev : parent;