From 10a8b750a03b9c8af968b0be9a1b65ddcf0e79cc Mon Sep 17 00:00:00 2001
From: Julian Uy <[EMAIL REDACTED]>
Date: Sun, 24 Dec 2023 14:44:33 +0000
Subject: [PATCH] Use common generic syscond for platforms with no cond
implementation
---
CMakeLists.txt | 3 +-
src/thread/psp/SDL_syscond.c | 202 ----------------------------------
src/thread/vita/SDL_syscond.c | 202 ----------------------------------
3 files changed, 2 insertions(+), 405 deletions(-)
delete mode 100644 src/thread/psp/SDL_syscond.c
delete mode 100644 src/thread/vita/SDL_syscond.c
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8af562830bdb..74c2102b6163 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2470,7 +2470,7 @@ elseif(VITA)
"${SDL3_SOURCE_DIR}/src/thread/vita/SDL_sysmutex.c"
"${SDL3_SOURCE_DIR}/src/thread/vita/SDL_syssem.c"
"${SDL3_SOURCE_DIR}/src/thread/vita/SDL_systhread.c"
- "${SDL3_SOURCE_DIR}/src/thread/vita/SDL_syscond.c"
+ "${SDL3_SOURCE_DIR}/src/thread/generic/SDL_syscond.c"
"${SDL3_SOURCE_DIR}/src/thread/generic/SDL_sysrwlock.c"
"${SDL3_SOURCE_DIR}/src/thread/generic/SDL_systls.c"
)
@@ -2601,6 +2601,7 @@ elseif(PSP)
if(SDL_THREADS)
set(SDL_THREAD_PSP 1)
sdl_glob_sources(
+ "${SDL3_SOURCE_DIR}/src/thread/generic/SDL_syscond.c"
"${SDL3_SOURCE_DIR}/src/thread/generic/SDL_systls.c"
"${SDL3_SOURCE_DIR}/src/thread/generic/SDL_sysrwlock.c"
"${SDL3_SOURCE_DIR}/src/thread/psp/*.c"
diff --git a/src/thread/psp/SDL_syscond.c b/src/thread/psp/SDL_syscond.c
deleted file mode 100644
index bfe4f42bac52..000000000000
--- a/src/thread/psp/SDL_syscond.c
+++ /dev/null
@@ -1,202 +0,0 @@
-/*
- Simple DirectMedia Layer
- Copyright (C) 1997-2023 Sam Lantinga <slouken@libsdl.org>
-
- This software is provided 'as-is', without any express or implied
- warranty. In no event will the authors be held liable for any damages
- arising from the use of this software.
-
- Permission is granted to anyone to use this software for any purpose,
- including commercial applications, and to alter it and redistribute it
- freely, subject to the following restrictions:
-
- 1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
- 2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
- 3. This notice may not be removed or altered from any source distribution.
-*/
-#include "SDL_internal.h"
-
-#ifdef SDL_THREAD_PSP
-
-/* An implementation of condition variables using semaphores and mutexes */
-/*
- This implementation borrows heavily from the BeOS condition variable
- implementation, written by Christopher Tate and Owen Smith. Thanks!
- */
-
-struct SDL_Condition
-{
- SDL_Mutex *lock;
- int waiting;
- int signals;
- SDL_Semaphore *wait_sem;
- SDL_Semaphore *wait_done;
-};
-
-/* Create a condition variable */
-SDL_Condition *SDL_CreateCondition(void)
-{
- SDL_Condition *cond;
-
- cond = (SDL_Condition *)SDL_malloc(sizeof(SDL_Condition));
- if (cond) {
- cond->lock = SDL_CreateMutex();
- cond->wait_sem = SDL_CreateSemaphore(0);
- cond->wait_done = SDL_CreateSemaphore(0);
- cond->waiting = cond->signals = 0;
- if (!cond->lock || !cond->wait_sem || !cond->wait_done) {
- SDL_DestroyCondition(cond);
- cond = NULL;
- }
- }
- return cond;
-}
-
-/* Destroy a condition variable */
-void SDL_DestroyCondition(SDL_Condition *cond)
-{
- if (cond) {
- if (cond->wait_sem) {
- SDL_DestroySemaphore(cond->wait_sem);
- }
- if (cond->wait_done) {
- SDL_DestroySemaphore(cond->wait_done);
- }
- if (cond->lock) {
- SDL_DestroyMutex(cond->lock);
- }
- SDL_free(cond);
- }
-}
-
-/* Restart one of the threads that are waiting on the condition variable */
-int SDL_SignalCondition(SDL_Condition *cond)
-{
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* If there are waiting threads not already signalled, then
- signal the condition and wait for the thread to respond.
- */
- SDL_LockMutex(cond->lock);
- if (cond->waiting > cond->signals) {
- ++cond->signals;
- SDL_PostSemaphore(cond->wait_sem);
- SDL_UnlockMutex(cond->lock);
- SDL_WaitSemaphore(cond->wait_done);
- } else {
- SDL_UnlockMutex(cond->lock);
- }
-
- return 0;
-}
-
-/* Restart all threads that are waiting on the condition variable */
-int SDL_BroadcastCondition(SDL_Condition *cond)
-{
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* If there are waiting threads not already signalled, then
- signal the condition and wait for the thread to respond.
- */
- SDL_LockMutex(cond->lock);
- if (cond->waiting > cond->signals) {
- int i, num_waiting;
-
- num_waiting = (cond->waiting - cond->signals);
- cond->signals = cond->waiting;
- for (i = 0; i < num_waiting; ++i) {
- SDL_PostSemaphore(cond->wait_sem);
- }
- /* Now all released threads are blocked here, waiting for us.
- Collect them all (and win fabulous prizes!) :-)
- */
- SDL_UnlockMutex(cond->lock);
- for (i = 0; i < num_waiting; ++i) {
- SDL_WaitSemaphore(cond->wait_done);
- }
- } else {
- SDL_UnlockMutex(cond->lock);
- }
-
- return 0;
-}
-
-/* Wait on the condition variable for at most 'timeoutNS' nanoseconds.
- The mutex must be locked before entering this function!
- The mutex is unlocked during the wait, and locked again after the wait.
-
-Typical use:
-
-Thread A:
- SDL_LockMutex(lock);
- while ( ! condition ) {
- SDL_WaitCondition(cond, lock);
- }
- SDL_UnlockMutex(lock);
-
-Thread B:
- SDL_LockMutex(lock);
- ...
- condition = true;
- ...
- SDL_SignalCondition(cond);
- SDL_UnlockMutex(lock);
- */
-int SDL_WaitConditionTimeoutNS(SDL_Condition *cond, SDL_Mutex *mutex, Sint64 timeoutNS)
-{
- int retval;
-
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* Obtain the protection mutex, and increment the number of waiters.
- This allows the signal mechanism to only perform a signal if there
- are waiting threads.
- */
- SDL_LockMutex(cond->lock);
- ++cond->waiting;
- SDL_UnlockMutex(cond->lock);
-
- /* Unlock the mutex, as is required by condition variable semantics */
- SDL_UnlockMutex(mutex);
-
- /* Wait for a signal */
- retval = SDL_WaitSemaphoreTimeout(cond->wait_sem, timeoutNS);
-
- /* Let the signaler know we have completed the wait, otherwise
- the signaler can race ahead and get the condition semaphore
- if we are stopped between the mutex unlock and semaphore wait,
- giving a deadlock. See the following URL for details:
- http://www-classic.be.com/aboutbe/benewsletter/volume_III/Issue40.html
- */
- SDL_LockMutex(cond->lock);
- if (cond->signals > 0) {
- /* If we timed out, we need to eat a condition signal */
- if (retval > 0) {
- SDL_WaitSemaphore(cond->wait_sem);
- }
- /* We always notify the signal thread that we are done */
- SDL_PostSemaphore(cond->wait_done);
-
- /* Signal handshake complete */
- --cond->signals;
- }
- --cond->waiting;
- SDL_UnlockMutex(cond->lock);
-
- /* Lock the mutex, as is required by condition variable semantics */
- SDL_LockMutex(mutex);
-
- return retval;
-}
-
-#endif /* SDL_THREAD_PSP */
diff --git a/src/thread/vita/SDL_syscond.c b/src/thread/vita/SDL_syscond.c
deleted file mode 100644
index fc8e1c9e36d5..000000000000
--- a/src/thread/vita/SDL_syscond.c
+++ /dev/null
@@ -1,202 +0,0 @@
-/*
- Simple DirectMedia Layer
- Copyright (C) 1997-2023 Sam Lantinga <slouken@libsdl.org>
-
- This software is provided 'as-is', without any express or implied
- warranty. In no event will the authors be held liable for any damages
- arising from the use of this software.
-
- Permission is granted to anyone to use this software for any purpose,
- including commercial applications, and to alter it and redistribute it
- freely, subject to the following restrictions:
-
- 1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
- 2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
- 3. This notice may not be removed or altered from any source distribution.
-*/
-#include "SDL_internal.h"
-
-#ifdef SDL_THREAD_VITA
-
-/* An implementation of condition variables using semaphores and mutexes */
-/*
- This implementation borrows heavily from the BeOS condition variable
- implementation, written by Christopher Tate and Owen Smith. Thanks!
- */
-
-struct SDL_Condition
-{
- SDL_Mutex *lock;
- int waiting;
- int signals;
- SDL_Semaphore *wait_sem;
- SDL_Semaphore *wait_done;
-};
-
-/* Create a condition variable */
-SDL_Condition *SDL_CreateCondition(void)
-{
- SDL_Condition *cond;
-
- cond = (SDL_Condition *)SDL_malloc(sizeof(SDL_Condition));
- if (cond) {
- cond->lock = SDL_CreateMutex();
- cond->wait_sem = SDL_CreateSemaphore(0);
- cond->wait_done = SDL_CreateSemaphore(0);
- cond->waiting = cond->signals = 0;
- if (!cond->lock || !cond->wait_sem || !cond->wait_done) {
- SDL_DestroyCondition(cond);
- cond = NULL;
- }
- }
- return cond;
-}
-
-/* Destroy a condition variable */
-void SDL_DestroyCondition(SDL_Condition *cond)
-{
- if (cond) {
- if (cond->wait_sem) {
- SDL_DestroySemaphore(cond->wait_sem);
- }
- if (cond->wait_done) {
- SDL_DestroySemaphore(cond->wait_done);
- }
- if (cond->lock) {
- SDL_DestroyMutex(cond->lock);
- }
- SDL_free(cond);
- }
-}
-
-/* Restart one of the threads that are waiting on the condition variable */
-int SDL_SignalCondition(SDL_Condition *cond)
-{
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* If there are waiting threads not already signalled, then
- signal the condition and wait for the thread to respond.
- */
- SDL_LockMutex(cond->lock);
- if (cond->waiting > cond->signals) {
- ++cond->signals;
- SDL_PostSemaphore(cond->wait_sem);
- SDL_UnlockMutex(cond->lock);
- SDL_WaitSemaphore(cond->wait_done);
- } else {
- SDL_UnlockMutex(cond->lock);
- }
-
- return 0;
-}
-
-/* Restart all threads that are waiting on the condition variable */
-int SDL_BroadcastCondition(SDL_Condition *cond)
-{
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* If there are waiting threads not already signalled, then
- signal the condition and wait for the thread to respond.
- */
- SDL_LockMutex(cond->lock);
- if (cond->waiting > cond->signals) {
- int i, num_waiting;
-
- num_waiting = (cond->waiting - cond->signals);
- cond->signals = cond->waiting;
- for (i = 0; i < num_waiting; ++i) {
- SDL_PostSemaphore(cond->wait_sem);
- }
- /* Now all released threads are blocked here, waiting for us.
- Collect them all (and win fabulous prizes!) :-)
- */
- SDL_UnlockMutex(cond->lock);
- for (i = 0; i < num_waiting; ++i) {
- SDL_WaitSemaphore(cond->wait_done);
- }
- } else {
- SDL_UnlockMutex(cond->lock);
- }
-
- return 0;
-}
-
-/* Wait on the condition variable for at most 'timeoutNS' nanoseconds.
- The mutex must be locked before entering this function!
- The mutex is unlocked during the wait, and locked again after the wait.
-
-Typical use:
-
-Thread A:
- SDL_LockMutex(lock);
- while ( ! condition ) {
- SDL_WaitCondition(cond, lock);
- }
- SDL_UnlockMutex(lock);
-
-Thread B:
- SDL_LockMutex(lock);
- ...
- condition = true;
- ...
- SDL_SignalCondition(cond);
- SDL_UnlockMutex(lock);
- */
-int SDL_WaitConditionTimeoutNS(SDL_Condition *cond, SDL_Mutex *mutex, Sint64 timeoutNS)
-{
- int retval;
-
- if (!cond) {
- return SDL_InvalidParamError("cond");
- }
-
- /* Obtain the protection mutex, and increment the number of waiters.
- This allows the signal mechanism to only perform a signal if there
- are waiting threads.
- */
- SDL_LockMutex(cond->lock);
- ++cond->waiting;
- SDL_UnlockMutex(cond->lock);
-
- /* Unlock the mutex, as is required by condition variable semantics */
- SDL_UnlockMutex(mutex);
-
- /* Wait for a signal */
- retval = SDL_WaitSemaphoreTimeoutNS(cond->wait_sem, timeoutNS);
-
- /* Let the signaler know we have completed the wait, otherwise
- the signaler can race ahead and get the condition semaphore
- if we are stopped between the mutex unlock and semaphore wait,
- giving a deadlock. See the following URL for details:
- http://www-classic.be.com/aboutbe/benewsletter/volume_III/Issue40.html
- */
- SDL_LockMutex(cond->lock);
- if (cond->signals > 0) {
- /* If we timed out, we need to eat a condition signal */
- if (retval > 0) {
- SDL_WaitSemaphore(cond->wait_sem);
- }
- /* We always notify the signal thread that we are done */
- SDL_PostSemaphore(cond->wait_done);
-
- /* Signal handshake complete */
- --cond->signals;
- }
- --cond->waiting;
- SDL_UnlockMutex(cond->lock);
-
- /* Lock the mutex, as is required by condition variable semantics */
- SDL_LockMutex(mutex);
-
- return retval;
-}
-
-#endif /* SDL_THREAD_VITA */