From 9c285f238bcca35957bcb339d89429553ba91656 Mon Sep 17 00:00:00 2001
From: Ozkan Sezer <[EMAIL REDACTED]>
Date: Sat, 1 May 2021 14:01:02 +0300
Subject: [PATCH] added FIXME about respecting 1.2 env vars for defining audio
format
hand-picked from the cdrom compat patch of icculus.
---
src/SDL12_compat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/SDL12_compat.c b/src/SDL12_compat.c
index 93eb1a2..e492b64 100644
--- a/src/SDL12_compat.c
+++ b/src/SDL12_compat.c
@@ -5095,7 +5095,7 @@ SDL_OpenAudio(SDL_AudioSpec *want, SDL_AudioSpec *obtained)
AudioCallbackWrapperData *data;
int retval;
- /* SDL2 uses a NULL callback to mean "we play to use SDL_QueueAudio()" */
+ /* SDL2 uses a NULL callback to mean "we plan to use SDL_QueueAudio()" */
if (want && (want->callback == NULL)) {
return SDL20_SetError("Callback can't be NULL");
}
@@ -5110,6 +5110,7 @@ SDL_OpenAudio(SDL_AudioSpec *want, SDL_AudioSpec *obtained)
want->userdata = data;
/* to avoid receiving a possible incompatible configuration
* from SDL2, always pass NULL as the 'obtained' pointer. */
+ FIXME("Respect 1.2 environment variables for defining format here.");
if (!want->format) {
want->format = AUDIO_S16SYS;
}