Compiler warnings (-pedantic) [patch attached]

SDL Development
1

Hi,

bugzilla throws an internal server error for me - so I try it via
mailinglist:

If you install the joystick headers - you get warnings if your product
is compiled with -pedantic.

The attached patch fixes this
-------------- next part --------------
A non-text attachment was scrubbed…
Name: fixed-pedantic-compiler-warning-and-renamed-struct-variables.diff
Type: text/x-patch
Size: 3109 bytes
Desc: not available
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20130226/4cd69167/attachment.bin

2

OK, I can see where this warning comes from (nameless union), but I
don’t understand what this specific change has to do with that:

  • SDL_GameControllerBindType m_eBindType;
  • SDL_GameControllerBindType bindType;

Was there any reason for that change? (although I agree that I prefer
it without the Hungarian notation)

2013/2/26, Martin Gerhardy <martin.gerhardy at gmail.com>:> Hi,

bugzilla throws an internal server error for me - so I try it via
mailinglist:

If you install the joystick headers - you get warnings if your product
is compiled with -pedantic.

The attached patch fixes this

3

Isn’t the point of -pedantic to emit compiler warnings so silly that a
reasonable person would ignore them?On 02/26/2013 08:43 AM, Sik the hedgehog wrote:

OK, I can see where this warning comes from (nameless union), but I
don’t understand what this specific change has to do with that:

  • SDL_GameControllerBindType m_eBindType;
  • SDL_GameControllerBindType bindType;

Was there any reason for that change? (although I agree that I prefer
it without the Hungarian notation)

2013/2/26, Martin Gerhardy <martin.gerhardy at gmail.com>:

Hi,

bugzilla throws an internal server error for me - so I try it via
mailinglist:

If you install the joystick headers - you get warnings if your product
is compiled with -pedantic.

The attached patch fixes this

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

4

No, the only reason is that this is exposed to the user - and it’s not
the notation that is used for other “external” types.Am 26.02.2013 14:43, schrieb Sik the hedgehog:

OK, I can see where this warning comes from (nameless union), but I
don’t understand what this specific change has to do with that:

  • SDL_GameControllerBindType m_eBindType;
  • SDL_GameControllerBindType bindType;

Was there any reason for that change? (although I agree that I prefer
it without the Hungarian notation)