DirectInput joystick driver's XInput detection broken on Windows 10 Anniversary Update

SDL Development
1

Hi,

We use the XInput detection code from SDL’s DirectInput joystick code
in Mumble (https://www.mumble.info).

This is the code I am talking about:
https://hg.libsdl.org/SDL/file/e8281b14970c/src/joystick/windows/SDL_dinputjoystick.c#l238

We just received a bug report that the detection is broken on Windows
10 Anniversary Update (1607):

I debugged it for a bit, and it doesn’t seem like the “IG_” check
works anymore when using the anniversary update. The “IG_” check is
this:
https://hg.libsdl.org/SDL/file/e8281b14970c/src/joystick/windows/SDL_dinputjoystick.c#l296

For now, we’ve worked around the issue by adding GUIDs for
wired/wireless/bluetooth Xbox One controllers to the list of well
known XInput devices:

This works around the issue for people using Xbox One controllers.

If there is any interest, feel free to copy the GUIDs from the PR
above into SDL, under SDL’s MIT license.

Thanks,
Mikkel

2

Hi,

We use the XInput detection code from SDL’s DirectInput joystick code
in Mumble (https://www.mumble.info).

This is the code I am talking about:
SDL/src/joystick/windows/SDL_dinputjoystick.c at 24bc00a831f74cd95255f94660d4763db4b6761e · libsdl-org/SDL · GitHub

We just received a bug report that the detection is broken on Windows
10 Anniversary Update (1607):
windows 10 anniversary update (x64) PTT not working with Xbox Controllers · Issue #2483 · mumble-voip/mumble · GitHub

I debugged it for a bit, and it doesn’t seem like the “IG_” check
works anymore when using the anniversary update. The “IG_” check is
this:
SDL/src/joystick/windows/SDL_dinputjoystick.c at 24bc00a831f74cd95255f94660d4763db4b6761e · libsdl-org/SDL · GitHub

For now, we’ve worked around the issue by adding GUIDs for
wired/wireless/bluetooth Xbox One controllers to the list of well
known XInput devices:

3rdparty/xinputcheck-src: add Xbox One controller GUIDs to avoid device list querying for Xbox One controllers. by mkrautz · Pull Request #2484 · mumble-voip/mumble · GitHub

This works around the issue for people using Xbox One controllers.

If there is any interest, feel free to copy the GUIDs from the PR
above into SDL, under SDL’s MIT license.

SDL uses zlib licence, not MIT license :wink:

Thanks,
Mikkel

Cheers,
DanielOn 08/04/2016 02:35 AM, Mikkel Krautz wrote:

3

Whoops.

If there’s any interest, feel free to copy the GUIDs from the PR above
into SDL, under SDL’s zlib license. :-)On Thu, Aug 4, 2016 at 2:50 AM, Daniel Gibson wrote:

On 08/04/2016 02:35 AM, Mikkel Krautz wrote:

If there is any interest, feel free to copy the GUIDs from the PR
above into SDL, under SDL’s MIT license.

SDL uses zlib licence, not MIT license :wink:

4

I’ve moved this thread to Bugzilla:
https://bugzilla.libsdl.org/show_bug.cgi?id=3403

Please keep up with the issue there instead. :slight_smile: