Invalid SDL application's icon in KDE

Hi,

I’ve noticed that SDL games have invalid icon at taskbar when running in
KDE (this icon: /usr/share/icons/oxygen/32x32/apps/xorg.png).
In rest of DEs (like a XFCE or GNOME) icon is ok.
So I wonder if it’s KDE specific or SDL specific issue? And can we handle
it in some way?

Thanks in advance!–
Best regards,
Sam Protsenko

I imagine that’s what KDE uses as a placeholder when the window
doesn’t specify its own icon? Pretty sure this also happens in GNOME
(albeit with a different icon) and this is true even outside SDL.

Unless you’re setting the icon and KDE isn’t using it, then I guess
that’s indeed an issue.

2013/2/9, Joe <joe.skb7 at gmail.com>:> Hi,

I’ve noticed that SDL games have invalid icon at taskbar when running in
KDE (this icon: /usr/share/icons/oxygen/32x32/apps/xorg.png).
In rest of DEs (like a XFCE or GNOME) icon is ok.
So I wonder if it’s KDE specific or SDL specific issue? And can we handle
it in some way?

Thanks in advance!


Best regards,
Sam Protsenko

I’ve checked SDL applications with “xprop” tool. Seems like there is
_NET_WM_ICON property here. For non-SDL applications such a property is
present.
So I’ve found this SDL patch:
http://lists.libsdl.org/pipermail/commits-libsdl.org/2012-October/005808.html
But I’m not sure that this patch applied for my SDL version.
My SDL version is 1.2.15 (in Debian testing).

Seems like KDE uses _NET_WM_ICON for taskbar icon. Does it correct?
And probably XFCE, Unity etc don’t use this property, so in these DE
taskbar icon is correct.On Sat, Feb 9, 2013 at 3:41 PM, Sik the hedgehog <sik.the.hedgehog at gmail.com wrote:

I imagine that’s what KDE uses as a placeholder when the window
doesn’t specify its own icon? Pretty sure this also happens in GNOME
(albeit with a different icon) and this is true even outside SDL.

Unless you’re setting the icon and KDE isn’t using it, then I guess
that’s indeed an issue.

2013/2/9, Joe <@Joe1>:

Hi,

I’ve noticed that SDL games have invalid icon at taskbar when running in
KDE (this icon: /usr/share/icons/oxygen/32x32/apps/xorg.png).
In rest of DEs (like a XFCE or GNOME) icon is ok.
So I wonder if it’s KDE specific or SDL specific issue? And can we handle
it in some way?

Thanks in advance!


Best regards,
Sam Protsenko


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Best regards,
Sam Protsenko

OK, seems this is KDE issue:
http://lists.kde.org/?l=kde-devel&m=136041966400524&w=2On Sat, Feb 9, 2013 at 4:23 PM, Joe <@Joe1> wrote:

I’ve checked SDL applications with “xprop” tool. Seems like there is
_NET_WM_ICON property here. For non-SDL applications such a property is
present.
So I’ve found this SDL patch:
http://lists.libsdl.org/pipermail/commits-libsdl.org/2012-October/005808.html
But I’m not sure that this patch applied for my SDL version.
My SDL version is 1.2.15 (in Debian testing).

Seems like KDE uses _NET_WM_ICON for taskbar icon. Does it correct?
And probably XFCE, Unity etc don’t use this property, so in these DE
taskbar icon is correct.

On Sat, Feb 9, 2013 at 3:41 PM, Sik the hedgehog < sik.the.hedgehog at gmail.com> wrote:

I imagine that’s what KDE uses as a placeholder when the window
doesn’t specify its own icon? Pretty sure this also happens in GNOME
(albeit with a different icon) and this is true even outside SDL.

Unless you’re setting the icon and KDE isn’t using it, then I guess
that’s indeed an issue.

2013/2/9, Joe <@Joe1>:

Hi,

I’ve noticed that SDL games have invalid icon at taskbar when running in
KDE (this icon: /usr/share/icons/oxygen/32x32/apps/xorg.png).
In rest of DEs (like a XFCE or GNOME) icon is ok.
So I wonder if it’s KDE specific or SDL specific issue? And can we
handle
it in some way?

Thanks in advance!


Best regards,
Sam Protsenko


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Best regards,
Sam Protsenko


Best regards,
Sam Protsenko

So I’ve found this SDL patch:
http://lists.libsdl.org/pipermail/commits-libsdl.org/2012-October/005808.html
But I’m not sure that this patch applied for my SDL version.
My SDL version is 1.2.15 (in Debian testing).

Yeah, that patch was for SDL2, which is pretty wildly different from the
1.2 branch.

Seems like KDE uses _NET_WM_ICON for taskbar icon. Does it correct?
And probably XFCE, Unity etc don’t use this property, so in these DE
taskbar icon is correct.

There’s an older way to set your window’s icon, which SDL 1.2 uses (and
SDL2 uses if _NET_WM_ICON isn’t supported by your window manager).

To be clear, though: an application has to set its icon at runtime, or
you’ll probably get an ugly default icon in any desktop environment. SDL
won’t do it by default unless the app asks it to do so (although I
suppose you could do a .desktop file or whatever so it launches with a
proper icon right from the start?).

I don’t plan to add _NET_WM_ICON support to SDL 1.2, but I’ll accept a
patch for it if someone else does it.

–ryan.

Thank you for detailed explanation! Unfortunately, I’m not into SDL source
code, so I’m not sure that I can do such a patch for 1.2 (I will try to ask
one guy (familiar to SDL) to do that, but not sure he is really interested
in it). But it seems there is no need to do that – desktop environments
other than KDE handle taskbar icon correctly. Issue already root caused –
it’s in KDE (libtaskbar), you can find conversations here:
http://lists.kde.org/?t=136041482800002&r=1&w=2 . So I’m gonna file the bug
to KDE bugtracker system.On Sat, Feb 9, 2013 at 6:51 PM, Ryan C. Gordon wrote:

So I’ve found this SDL patch:

http://lists.libsdl.org/pipermail/commits-libsdl.org/
2012-October/005808.htmlhttp://lists.libsdl.org/pipermail/commits-libsdl.org/2012-October/005808.html
But I’m not sure that this patch applied for my SDL version.
My SDL version is 1.2.15 (in Debian testing).

Yeah, that patch was for SDL2, which is pretty wildly different from the
1.2 branch.

Seems like KDE uses _NET_WM_ICON for taskbar icon. Does it correct?

And probably XFCE, Unity etc don’t use this property, so in these DE
taskbar icon is correct.

There’s an older way to set your window’s icon, which SDL 1.2 uses (and
SDL2 uses if _NET_WM_ICON isn’t supported by your window manager).

To be clear, though: an application has to set its icon at runtime, or
you’ll probably get an ugly default icon in any desktop environment. SDL
won’t do it by default unless the app asks it to do so (although I suppose
you could do a .desktop file or whatever so it launches with a proper icon
right from the start?).

I don’t plan to add _NET_WM_ICON support to SDL 1.2, but I’ll accept a
patch for it if someone else does it.

–ryan.

_____________**
SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/**listinfo.cgi/sdl-libsdl.orghttp://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


Best regards,
Sam Protsenko