[PATCH] DirectX

SDL Development
1

???,

two typos (bugs) in sdl_dx5video.c:

function DX5_AllocDDSurface:

    if ( (flag & SDL_HWSURFACE) == SDL_SWSURFACE ) {
            if ( ddsd.lpSurface != surface->pixels ) {
                    SDL_SetError("DDraw didn't use SDL surface memory");
                    goto error_end;
            }
            if (

look at the first line! It must be
if ( (flag & SDL_SWSURFACE) == SDL_SWSURFACE ) {

The same at the beginning of DX5_CheckHWBlit!–
Best regards,
Dmitry Yakimov, ISDEF member
ActiveKitten.com

2

???,

two typos (bugs) in sdl_dx5video.c:

function DX5_AllocDDSurface:

    if ( (flag & SDL_HWSURFACE) == SDL_SWSURFACE ) {
            if ( ddsd.lpSurface != surface->pixels ) {
                    SDL_SetError("DDraw didn't use SDL surface memory");
                    goto error_end;
            }
            if (

look at the first line! It must be
if ( (flag & SDL_SWSURFACE) == SDL_SWSURFACE ) {

Must be? The value of SDL_SWSURFACE is 0 (zero): check ‘SDL_video.h’,

cheers,
John Popplewell.On Sun, Oct 31, 2004 at 12:23:16AM +0400, Dmitry Yakimov wrote:

The same at the beginning of DX5_CheckHWBlit!

–
Best regards,
Dmitry Yakimov, ISDEF member
ActiveKitten.com

SDL mailing list
SDL at libsdl.org
http://www.libsdl.org/mailman/listinfo/sdl

3

Dmitry Yakimov wrote:

???,

two typos (bugs) in sdl_dx5video.c:

function DX5_AllocDDSurface:

   if ( (flag & SDL_HWSURFACE) == SDL_SWSURFACE ) {
           if ( ddsd.lpSurface != surface->pixels ) {
                   SDL_SetError("DDraw didn't use SDL surface memory");
                   goto error_end;
           }
           if (

look at the first line! It must be
if ( (flag & SDL_SWSURFACE) == SDL_SWSURFACE ) {

No, it musn’t. That’s the correct test for hardware surface detection.

Stephane