[patch] missing MMX blit function

SDL Development
1

ConvertMMXpII32_24RGB888() is used nowhere, yet is fully functional.
This patch fixes the problem.–
Sam.
-------------- next part --------------
diff -puriN SDL-1.2.9.orig/src/video/SDL_blit_N.c SDL-1.2.9/src/video/SDL_blit_N.c
— SDL-1.2.9.orig/src/video/SDL_blit_N.c 2005-04-20 07:57:39.000000000 +0200
+++ SDL-1.2.9/src/video/SDL_blit_N.c 2006-03-01 16:23:06.000000000 +0100
@@ -2125,6 +2127,8 @@ static const struct blit_table normal_bl
1, ConvertMMXpII32_16BGR555, ConvertMMX, NO_ALPHA },
{ 0x00FF0000,0x0000FF00,0x000000FF, 2, 0x0000001F,0x000003E0,0x00007C00,
0, ConvertX86p32_16BGR555, ConvertX86, NO_ALPHA },

  • { 0x00FF0000,0x0000FF00,0x000000FF, 3, 0x00FF0000,0x0000FF00,0x000000FF,
  •  1, ConvertMMXpII32_24RGB888, ConvertMMX, NO_ALPHA },
    { 0x00FF0000,0x0000FF00,0x000000FF, 3, 0x00FF0000,0x0000FF00,0x000000FF,
    0, ConvertX86p32_24RGB888, ConvertX86, NO_ALPHA },
    { 0x00FF0000,0x0000FF00,0x000000FF, 3, 0x000000FF,0x0000FF00,0x00FF0000,
2

Sam Hocevar wrote:

ConvertMMXpII32_24RGB888() is used nowhere, yet is fully functional.
This patch fixes the problem.

There is a comment about performance issues with this function in the
hermes sources. Does enabling it leads an improvement ?

Stephane

3

ConvertMMXpII32_24RGB888() is used nowhere, yet is fully functional.
This patch fixes the problem.

There is a comment about performance issues with this function in the
hermes sources. Does enabling it leads an improvement ?

I could only witness an average 4% improvement on a 600 MHz Pentium
III (running a modified testoverlay that repeats its main loop 100
times). Not very impressive, but I think most of the the CPU is spent by
the X server displaying the image anyway.

This is also why I was looking for a test program for all these blit
routines, it would help benchmark offline blits.On Thu, Mar 02, 2006, Stephane Marchesin wrote:

–
Sam.