[patch] SDL 1.6 (SVN) fails building deployment with Xcode (broken in r5118)

SDL Development
#1

When using deployment in Xcode we use 10.4 SDK for PPC & i386 and 10.6
SDK for x86_64 unfortunately MAC_OS_X_VERSION_10_6 is defined only in
10.6 SDK, in older SDKs it is undefined which makes >= comparison
return always TRUTH, so the GCC complains about undefined
, even if the original intention was to omit
on older SDKs.

Solution, don’t relay on MAC_OS_X_VERSION_10_6 but use OSX revision
number 1060 directly as SDL does in many other places.

Here’s a patch:

Index: src/video/cocoa/SDL_cocoawindow.h===================================================================
— src/video/cocoa/SDL_cocoawindow.h (revision 5170)
+++ src/video/cocoa/SDL_cocoawindow.h (working copy)
@@ -29,7 +29,7 @@
typedef struct SDL_WindowData SDL_WindowData;

/* INDENT-OFF */
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_6
+#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
@interface Cocoa_WindowListener : NSResponder {
#else
@interface Cocoa_WindowListener : NSResponder {

Regards,

Adam Strzelecki | nanoant.com

#2

Got it, thanks!On Thu, Oct 22, 2009 at 9:34 AM, Adam Strzelecki wrote:

When using deployment in Xcode we use 10.4 SDK for PPC & i386 and 10.6 SDK
for x86_64 unfortunately MAC_OS_X_VERSION_10_6 is defined only in 10.6 SDK,
in older SDKs it is undefined which makes >= comparison return always TRUTH,
so the GCC complains about undefined , even if the
original intention was to omit on older SDKs.

Solution, don’t relay on MAC_OS_X_VERSION_10_6 but use OSX revision number
1060 directly as SDL does in many other places.

Here’s a patch:

Index: src/video/cocoa/SDL_cocoawindow.h

— src/video/cocoa/SDL_cocoawindow.h ? (revision 5170)
+++ src/video/cocoa/SDL_cocoawindow.h ? (working copy)
@@ -29,7 +29,7 @@
?typedef struct SDL_WindowData SDL_WindowData;

?/* INDENT-OFF */
-#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_6
+#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
?@interface Cocoa_WindowListener : NSResponder {
?#else
?@interface Cocoa_WindowListener : NSResponder {

Regards,

Adam Strzelecki | nanoant.com

SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

–
-Sam Lantinga, Founder and President, Galaxy Gameworks LLC