Possible =/== typo in SDL 1.2.15 prerelease code

I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:

 } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {

“:src:video:SDL_video.c”; line 990 #Warning 2: possible unintended assignment

I discussed this with another programmer and we came to the conclusion
that this is probably a typo.

I have checked the latest mercurial sources, and the possible typo is
still there.

Bl0ckeduser

Nice catch, thanks!On Tue, Jan 10, 2012 at 9:36 PM, Bl0ckeduser wrote:

I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:

} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {

“:src:video:SDL_video.c”; line 990 #Warning 2: possible unintended
assignment

I discussed this with another programmer and we came to the conclusion
that this is probably a typo.

I have checked the latest mercurial sources, and the possible typo is
still there.

Bl0ckeduser


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org