Doing some digging, I came across https://bugzilla.libsdl.org/show_bug.cgi?id=2730 . Now, I can see that this
patch isn’t brilliant (codestyle, tabs vs spaces, etc), but if I improve
it, is there a reasonable chance of getting it included upstream?
Thanks,
Charles
PS: I notice the Source snapshot hasn’t been updated in over a month, is
there a reason for that?
Doing some digging, I came across https://bugzilla.libsdl.org/show_bug.cgi?id=2730 . Now, I can see that
this patch isn’t brilliant (codestyle, tabs vs spaces, etc), but if I
improve it, is there a reasonable chance of getting it included upstream?
That specific patch is sort of big and scary, but the functionality is
absolutely appropriate for inclusion. However, we really want to get
2.0.4 finished and I’d be nervous about changes to that code, since
introducing a bug there basically hoses all Linux users.
thanks for looking at my patch. It didn’t feel that much of a change when I created it.
For me SDL with my fix works well since august Mint Linux x86_64 + Pandaboard Ubuntu (Just as information, not intended as recommendation for adding it in 2.0.4).
As for the codestyle: What is the wanted SDL2 codestyle, I did not find any recommendations (I will update my eclipse auto-formatter).
I also thought about adding the same functionality to alsa, but wanted to wait if my first patch is accepted or not.
br------------------------
void (*segfault)(void) = 0;
int main(int argc, char **argv){segfault(); return 0;}
//Should not work, but does what told
I’m not entirely sure what the recommended codestyle is either - I just
looked at the existing code! Which basically seems to be - 4-spaces as
indentation, "if (…) {"
I’m also not a fan of the ThreadInit method - it loses debugging
information and just gives an “out of memory” error, which may not be the
case. (Also, the method names (for DeInit as well) don’t really describe
very well what the function does, imo).
There’s also some code that is (very nearly) duplicated in
PULSEAUDIO_OpenDevice
CharlesOn 12 February 2015 at 11:41, Charles Pigott <@Charles_Pigott> wrote:
---------- Forwarded message ----------
From: dfrizel <dominik.frizel at gmx.at>
Date: 12 February 2015 at 09:08
Subject: Re: [SDL] Pulseaudio device detection
To: sdl at lists.libsdl.org
Hi,
thanks for looking at my patch. It didn’t feel that much of a change when
I created it.
For me SDL with my fix works well since august Mint Linux x86_64 +
Pandaboard Ubuntu (Just as information, not intended as recommendation for
adding it in 2.0.4).
As for the codestyle: What is the wanted SDL2 codestyle, I did not find
any recommendations (I will update my eclipse auto-formatter).
I also thought about adding the same functionality to alsa, but wanted to
wait if my first patch is accepted or not.
br
void (*segfault)(void) = 0;
int main(int argc, char **argv){segfault(); return 0;}
//Should not work, but does what told [image: Smile]
