'repeat' flag on SDL_KeyboardEvent not being set on 2.0.5

Hi guys,

I’ve recently upgraded from 2.0.4 to 2.0.5 and noticed the ‘repeat’ flag on
SDL_KeyboardEvent is not being set properly anymore on my system.

I’m using Ubuntu 16.04, with the X11 backend (XLIB).

I’ve tried to create a bug report on bugzilla but I couldn’t set the
version to 2.0.5 there.

Best regards,
Daniel

Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.

I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.

Maybe using ‘hg bisect’ with checkkeys could help you locate the commit
that introduced this.

Alex.On 25/10/16 00:12, Daniel Ribeiro Maciel wrote:

Hi guys,

I’ve recently upgraded from 2.0.4 to 2.0.5 and noticed the ‘repeat’ flag on
SDL_KeyboardEvent is not being set properly anymore on my system.

I’m using Ubuntu 16.04, with the X11 backend (XLIB).

I’ve tried to create a bug report on bugzilla but I couldn’t set the
version to 2.0.5 there.

Best regards,
Daniel


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Found the culprit:

changeset: 10500:c3874aa1f2d1
user: Sam Lantinga
date: Sat Oct 08 11:30:07 2016 -0700
summary: Fixed building and using fcitx IME support on Linux

Trying to figure out what is wrong with it.On Mon, Oct 24, 2016 at 11:06 PM, Alex Baines wrote:

Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.

I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.

Maybe using ‘hg bisect’ with checkkeys could help you locate the commit
that introduced this.

Alex.

On 25/10/16 00:12, Daniel Ribeiro Maciel wrote:

Hi guys,

I’ve recently upgraded from 2.0.4 to 2.0.5 and noticed the ‘repeat’ flag
on
SDL_KeyboardEvent is not being set properly anymore on my system.

I’m using Ubuntu 16.04, with the X11 backend (XLIB).

I’ve tried to create a bug report on bugzilla but I couldn’t set the
version to 2.0.5 there.

Best regards,
Daniel


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Apparently the problem is that now I’m forced to have either
HAVE_IBUS_IBUS_H or HAVE_FCITX_FRONTEND_H defined.

I think SDL now expects ibus headers installed (or fcitx dev) otherwise
new_xmods will not be set to “@im=none” which is the cause of the problem.

I’m forcing has_dbus_ime_support to SDL_TRUE and everthing works as
expected.

If I install libibus-dev everything works as expected but I see no reason
to require ibus headers if they are not really required in this case?On Tue, Oct 25, 2016 at 12:05 AM, Daniel Ribeiro Maciel < @Daniel_Ribeiro_Macie> wrote:

Found the culprit:

changeset: 10500:c3874aa1f2d1
user: Sam Lantinga
date: Sat Oct 08 11:30:07 2016 -0700
summary: Fixed building and using fcitx IME support on Linux

Trying to figure out what is wrong with it.

On Mon, Oct 24, 2016 at 11:06 PM, Alex Baines wrote:

Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.

I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.

Maybe using ‘hg bisect’ with checkkeys could help you locate the commit
that introduced this.

Alex.

On 25/10/16 00:12, Daniel Ribeiro Maciel wrote:

Hi guys,

I’ve recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat’
flag on
SDL_KeyboardEvent is not being set properly anymore on my system.

I’m using Ubuntu 16.04, with the X11 backend (XLIB).

I’ve tried to create a bug report on bugzilla but I couldn’t set the
version to 2.0.5 there.

Best regards,
Daniel


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

I have added libibus-1.0-dev to my bootstrap script here. Thanks for the
help Alex.

Best regards,
DanielOn Tue, Oct 25, 2016 at 12:33 AM, Daniel Ribeiro Maciel < @Daniel_Ribeiro_Macie> wrote:

Apparently the problem is that now I’m forced to have either
HAVE_IBUS_IBUS_H or HAVE_FCITX_FRONTEND_H defined.

I think SDL now expects ibus headers installed (or fcitx dev) otherwise
new_xmods will not be set to “@im=none” which is the cause of the problem.

I’m forcing has_dbus_ime_support to SDL_TRUE and everthing works as
expected.

If I install libibus-dev everything works as expected but I see no reason
to require ibus headers if they are not really required in this case?

On Tue, Oct 25, 2016 at 12:05 AM, Daniel Ribeiro Maciel < @Daniel_Ribeiro_Macie> wrote:

Found the culprit:

changeset: 10500:c3874aa1f2d1
user: Sam Lantinga
date: Sat Oct 08 11:30:07 2016 -0700
summary: Fixed building and using fcitx IME support on Linux

Trying to figure out what is wrong with it.

On Mon, Oct 24, 2016 at 11:06 PM, Alex Baines wrote:

Hmm, some patches I wrote that made it into 2.0.5 related to x11
keyboard code, so this may be my fault.

I tried to reproduce the behaviour locally using the checkkeys test, but
that shows key repeats correctly.

Maybe using ‘hg bisect’ with checkkeys could help you locate the commit
that introduced this.

Alex.

On 25/10/16 00:12, Daniel Ribeiro Maciel wrote:

Hi guys,

I’ve recently upgraded from 2.0.4 to 2.0.5 and noticed the 'repeat’
flag on
SDL_KeyboardEvent is not being set properly anymore on my system.

I’m using Ubuntu 16.04, with the X11 backend (XLIB).

I’ve tried to create a bug report on bugzilla but I couldn’t set the
version to 2.0.5 there.

Best regards,
Daniel


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

If I install libibus-dev everything works as expected but I see no
reason to require ibus headers if they are not really required in this case?

This is probably an unintentional bug. I’ve added a “2.0.5” version to
Bugzilla; if you get a moment, please file a bug and we’ll look into this!

Thanks,
–ryan.

This is possibly related to https://bugzilla.libsdl.org/show_bug.cgi?id=3472

Yes, I got key repeated key up and down events. It is the same bug.On Thu, Oct 27, 2016 at 7:10 AM, sezero wrote:

This is possibly related to https://bugzilla.libsdl.org/
show_bug.cgi?id=3472


SDL mailing list
SDL at lists.libsdl.org
http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org