SDL 2.0.22 PRERELEASE

slouken · April 9, 2022, 1:35am

Thanks to all the people who contributed code and feedback, SDL 2.0.22 has been tagged on GitHub as 2.0.22-RC1 and is now available as a PRERELEASE build!

https://www.libsdl.org/tmp/download-2.0.php

Please report any issues at Issues · libsdl-org/SDL · GitHub

In addition to lots of bug fixes, here are the major changes in this release:
General:

Added SDL_RenderGetWindow() to get the window associated with a renderer
Added floating point rectangle functions:
- SDL_PointInFRect()
- SDL_FRectEmpty()
- SDL_FRectEquals()
- SDL_HasIntersectionF()
- SDL_IntersectFRect()
- SDL_UnionFRect()
- SDL_EncloseFPoints()
- SDL_IntersectFRectAndLine()
Added SDL_IsTextInputShown() which returns whether the IME window is currently shown
Added SDL_ClearComposition() to dismiss the composition window without disabling IME input
Added SDL_TEXTEDITING_EXT event for handling long composition text, and a hint SDL_HINT_IME_SUPPORT_EXTENDED_TEXT to enable it
Added the hint SDL_HINT_MOUSE_RELATIVE_MODE_CENTER to control whether the mouse should be constrained to the whole window or the center of the window when relative mode is enabled
The mouse is now automatically captured when mouse buttons are pressed, and the hint SDL_HINT_MOUSE_AUTO_CAPTURE allows you to control this behavior
Added the hint SDL_HINT_VIDEO_FOREIGN_WINDOW_OPENGL to let SDL know that a foreign window will be used with OpenGL
Added the hint SDL_HINT_VIDEO_FOREIGN_WINDOW_VULKAN to let SDL know that a foreign window will be used with Vulkan
Added the hint SDL_HINT_QUIT_ON_LAST_WINDOW_CLOSE to specify whether an SDL_QUIT event will be delivered when the last application window is closed
Added the hint SDL_HINT_JOYSTICK_ROG_CHAKRAM to control whether ROG Chakram mice show up as joysticks

Windows:

Added support for SDL_BLENDOPERATION_MINIMUM and SDL_BLENDOPERATION_MAXIMUM to the D3D9 renderer

Linux:

Added the hint SDL_HINT_X11_WINDOW_TYPE to specify the _NET_WM_WINDOW_TYPE of SDL windows

Android:

Added SDL_AndroidSendMessage() to send a custom command to the SDL java activity

es5804 · April 12, 2022, 9:47am

On Linux, it is not possible to use address sanitizer because of controller sorting commit: Sort controllers by the js* index on Linux · libsdl-org/SDL@7ea1b69 · GitHub

This is not a bug in SDL but it is quite annoying.

In SDL

To sort joysticks, SDL do nested call to scandir():

github.com

libsdl-org/SDL/blob/main/src/joystick/linux/SDL_sysjoystick.c#L685

    
      
          
          
if (!last_joy_detect_time || SDL_TICKS_PASSED(now, last_joy_detect_time + SDL_JOY_DETECT_INTERVAL_MS)) {
              struct stat sb;
          
          
    /* Opening input devices can generate synchronous device I/O, so avoid it if we can */
              if (stat("/dev/input", &sb) == 0 && sb.st_mtime != last_input_dir_mtime) {
                  int i, count;
                  struct dirent **entries;
                  char path[PATH_MAX];
          
          
        count = scandir("/dev/input", &entries, filter_entries, sort_entries);
                  for (i = 0; i < count; ++i) {
                      SDL_snprintf(path, SDL_arraysize(path), "/dev/input/%s", entries[i]->d_name);
                      MaybeAddDevice(path);
          
          
            free(entries[i]); /* This should NOT be SDL_free() */
                  }
                  free(entries); /* This should NOT be SDL_free() */
          
          
        last_input_dir_mtime = sb.st_mtime;
              }

LINUX_FallbackJoystickDetect() calls scandir() to list files in /dev/input and sorts them with sort_entries().

sort_entries() calls get_event_joystick_index() which calls scandir() to find js* file in /sys/class/input/event%d/device

In Address sanitizer

Address sanitizer stores comparison and sorting functions in global variables:

github.com

llvm/llvm-project/blob/e9c8d0ff71baba2702765d6cd173421d54883fee/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc#L4006

    
      
          #define INIT_XPG_STRERROR_R COMMON_INTERCEPT_FUNCTION(__xpg_strerror_r);
          #else
          #define INIT_XPG_STRERROR_R
          #endif
          
          
#if SANITIZER_INTERCEPT_SCANDIR
          typedef int (*scandir_filter_f)(const struct __sanitizer_dirent *);
          typedef int (*scandir_compar_f)(const struct __sanitizer_dirent **,
                                          const struct __sanitizer_dirent **);
          
          
static THREADLOCAL scandir_filter_f scandir_filter;
          static THREADLOCAL scandir_compar_f scandir_compar;
          
          
static int wrapped_scandir_filter(const struct __sanitizer_dirent *dir) {
            COMMON_INTERCEPTOR_UNPOISON_PARAM(1);
            COMMON_INTERCEPTOR_INITIALIZE_RANGE(dir, dir->d_reclen);
            return scandir_filter(dir);
          }
          
          
static int wrapped_scandir_compar(const struct __sanitizer_dirent **a,
                                            const struct __sanitizer_dirent **b) {

The inner call to scandir() reset both global variables to NULL, then the second comparison in the outer call of scandir() crash by calling a NULL function pointer.

sezero · April 12, 2022, 10:32am

On Linux, it is not possible to use address sanitizer because of controller sorting commit: Sort controllers by the js* index on Linux · libsdl-org/SDL@7ea1b69 · GitHub

Does Initialise scandir argument by meyraud705 · Pull Request #5518 · libsdl-org/SDL · GitHub fix things?

es5804 · April 12, 2022, 10:52am

No, this is a crash in address sanitizer and it should be fixed there. It would nice to have a workaround in SDL in the meantime but I don’t see how to do one.

smcv · April 13, 2022, 11:06am

Some issue reports:

Wayland-by-default in 2.0.22rc1 causes some games to regress · Issue #5527 · libsdl-org/SDL · GitHub
2.0.22rc1 regression in Tomb Raider (2013): black screen/unresponsive when loading game, "Error sending request: Resource temporarily unavailable" · Issue #5529 · libsdl-org/SDL · GitHub

(probably best to respond to those on the issue tracker rather than here).

andreas_g · April 15, 2022, 3:35pm

There is a regression in this release:

When I switch my application to fullscreen the contents of the window do not keep their aspect ratio. They are scaled to fill the whole screen.

My system: iMac early 2009, OS X v10.11.6
Affected application is Previous: https://sourceforge.net/projects/previous/

This problem already existed in earlier version but IIRC it was fixed in 2.0.18.

slouken · April 18, 2022, 7:38pm

Are you using SDL_RenderSetLogicalSize() to set a specific aspect ratio?

andreas_g · April 18, 2022, 8:37pm

Yes, the size of the renderer is set using SDL_RenderSetLogicalSize(sdlRenderer, width, height);

slouken · April 18, 2022, 9:11pm

Are you able to reproduce the problem with the testsprite2 test program?
./testsprite2 --logical 640x480 --resizable
On my M1 mac running macOS 12.3.1, when I press the maximize button, the window expands to a new space and shows the smiley faces scaled up with the correct aspect ratio.

andreas_g · April 19, 2022, 4:17pm

Where can I find the testsprite2 program?

I did more tests and have some additional details:
The problem only occurs, if I run my application with two windows (simulating two screens). Only the main window is affected. The problem also occurs when resizing the window, but it seems to only happen about 1 out of 3 tries. The problem also occurs or disappears if I just move a resized window around. The contents of the window get stretched or jump back to correct aspect ratio.

The problem definitely does not occur with the release version of SDL (2.0.20).

slouken · April 19, 2022, 4:31pm

The testsprite2 program is in the test subdirectory.

Can you please enter a bug so we can track this?

andreas_g · April 19, 2022, 6:01pm

Maybe someone else can file the bug for me. Due to my very outdated system I am currently unable to log into Github.

slouken · April 21, 2022, 5:44pm

This has been updated with bug fixes for release and has been tagged on GitHub as 2.0.22-RC2:
https://www.libsdl.org/tmp/download-2.0.php

slouken · April 21, 2022, 5:49pm

I just tried running
./testsprite2 --logical 640x480 --resizable --windows 2

I wasn’t able to get either window to stretch instead of re-aspect no matter how I dragged, moved, or maximized either window. Can you try it and let us know if you have repro steps?

andreas_g · April 22, 2022, 7:56am

Is there a binary of the program available anywhere?

The affected application binary can be downloaded here: Dropbox - Previous_2.4.zip - Simplify your life

You can active multiple Windows by adding NeXTdimension boards and selecting All display mode via Display preferences. All required supporting files can be found here: previous / Code / [r1126] /branches/branch_softfloat/src

slouken · April 22, 2022, 1:10pm

I’m at the NeXT prompt, but I can’t resize or maximize the window. Can you please send me e-mail at slouken@libsdl.org to continue diagnosing this issue?

slouken · April 23, 2022, 5:52pm

This has been updated with bug fixes for release and has been tagged on GitHub as 2.0.22-RC3:
https://www.libsdl.org/tmp/download-2.0.php

This should be ready to go as the final release, so please let us know ASAP if there are any regressions in this build.

Thanks!

rtrussell · April 24, 2022, 4:48pm

There’s a regression of some sort in respect of SDL_SetCursor(). With 2.0.20 my app is changing the cursor shape as I move the mouse over different areas, as it should, but with 2.0.22 it’s not changing. I suspect this is related to a change in the mouse capture behavior (is it possible that when the mouse is captured the cursor shape is locked?).

Edit: If I click the mouse in SDL’s window and then move it over the title bar the cursor shape is not changing back to the pointer as it should, it’s stuck in the shape I selected. This definitely looks to be related to the change in capture behavior.

sezero · April 25, 2022, 6:26pm

You should report this at Issues · libsdl-org/SDL · GitHub so that it doesn’t get lost.

rtrussell · April 26, 2022, 7:38am

I’m responding here because Sam asked the question here. I am not knowledgeable enough about SDL2 to report it at GitHub - that’s for developers not users!

The list of changes in 2.0.22 includes “The mouse is now automatically captured when mouse buttons are pressed” so I think that’s highly likely to be related to the regression. It breaks my app (in Windows, anyway), so I couldn’t use 2.0.22 unless it is fixed.

I expect it was missed by the automated test suite because only the visual appearance of the cursor is affected (in Windows, anyway)!