Small SDL_mixer patch

SDL Development
1

here’s a very quick patch. it adds mp3 support to the
"Mix_SetMusicPosition" function in SDL_mixer. some of my pygame users
are requesting this feature, so i’ve got to start by getting it into
SDL_mixer :]
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed…
Name: mixer_music.patch
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20020112/01306d9c/attachment.asc

2

here’s a very quick patch. it adds mp3 support to the
"Mix_SetMusicPosition" function in SDL_mixer. some of my pygame users
are requesting this feature, so i’ve got to start by getting it into
SDL_mixer :]

Got it. The semantics should probably be changed to "position in seconds"
to match the OGG format, and then documented in the header.

I haven’t worked with SMPEG in a while. Does the skip perform an abosolute
seek? I don’t think it does…

See ya,
-Sam Lantinga, Software Engineer, Blizzard Entertainment

3

Sam Lantinga wrote:

Got it. The semantics should probably be changed to "position in seconds"
to match the OGG format, and then documented in the header.

I haven’t worked with SMPEG in a while. Does the skip perform an abosolute
seek? I don’t think it does…

doh, you are proably right, looking over the smpeg header. i’ve been
using the SMPEG_Skip, but only when i first start playing the song, not
during. i suppose a quick insertion of SMPEG_rewind would ensure an
absolute position.

4

I’ve attached a small patch that cleans up the error reporting when an
unknown file type is passed to Mix_LoadWAV_RW. this patch adds some minimal
testing before branching off to the VOC loader, and unknown files now error
with “Unrecognized sound file type” instead of “Unrecognized file type (not
VOC)”.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed…
Name: clean_voc_error.patch
URL: http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20021016/b004b46d/attachment.asc

5

I’ve attached a small patch that cleans up the error reporting when an
unknown file type is passed to Mix_LoadWAV_RW. this patch adds some minimal
testing before branching off to the VOC loader, and unknown files now error
with “Unrecognized sound file type” instead of “Unrecognized file type (not
VOC)”.

Committed to CVS; thanks!

–ryan.